-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rtc_interface): add publisher to publish auto mode status #5845
feat(rtc_interface): add publisher to publish auto mode status #5845
Conversation
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
bbb5c1a
to
6770084
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5845 +/- ##
=======================================
Coverage 15.30% 15.31%
=======================================
Files 1740 1740
Lines 119846 119855 +9
Branches 36446 36450 +4
=======================================
+ Hits 18348 18353 +5
Misses 80969 80969
- Partials 20529 20533 +4
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
341d35e
into
autowarefoundation:main
…arefoundation#5845) add publisher to publish auto mode status Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…arefoundation#5845) add publisher to publish auto mode status Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…arefoundation#5845) (#1076) add publisher to publish auto mode status Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
…arefoundation#5845) add publisher to publish auto mode status Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Signed-off-by: karishma <karishma@interpl.ai>
…arefoundation#5845) add publisher to publish auto mode status Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Signed-off-by: karishma <karishma@interpl.ai>
…arefoundation#5845) add publisher to publish auto mode status Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…arefoundation#5845) add publisher to publish auto mode status Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…arefoundation#5845) add publisher to publish auto mode status Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Description
🤖[deprecated] Generated by Copilot at 6770084
This pull request enhances the
RTCInterface
module to publish its auto mode status using theAutoModeStatus
message type. It also improves the readability of the code by renaming a member variable. The changes affect the filesrtc_interface.hpp
andrtc_interface.cpp
.Tests performed
test with simple_planning_simulator
Switched between auto mode ⇔ manual mode for crosswalk module and confirmed the result is reflected to the topic info
Screencast from 2023年12月12日 16時46分03秒.webm
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.