Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rtc_interface): add publisher to publish auto mode status #5845

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Dec 12, 2023

Description

🤖[deprecated] Generated by Copilot at 6770084

This pull request enhances the RTCInterface module to publish its auto mode status using the AutoModeStatus message type. It also improves the readability of the code by renaming a member variable. The changes affect the files rtc_interface.hpp and rtc_interface.cpp.

image

Tests performed

test with simple_planning_simulator
Switched between auto mode ⇔ manual mode for crosswalk module and confirmed the result is reflected to the topic info
Screencast from 2023年12月12日 16時46分03秒.webm

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 12, 2023
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara kyoichi-sugahara marked this pull request as ready for review December 12, 2023 07:48
@kyoichi-sugahara kyoichi-sugahara added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 12, 2023
Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyoichi-sugahara kyoichi-sugahara enabled auto-merge (squash) December 12, 2023 08:36
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (6533c72) 15.30% compared to head (6770084) 15.31%.
Report is 3 commits behind head on main.

Files Patch % Lines
planning/rtc_interface/src/rtc_interface.cpp 53.84% 2 Missing and 4 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5845   +/-   ##
=======================================
  Coverage   15.30%   15.31%           
=======================================
  Files        1740     1740           
  Lines      119846   119855    +9     
  Branches    36446    36450    +4     
=======================================
+ Hits        18348    18353    +5     
  Misses      80969    80969           
- Partials    20529    20533    +4     
Flag Coverage Δ *Carryforward flag
differential 11.94% <53.84%> (?)
total 15.30% <ø> (-0.01%) ⬇️ Carriedforward from 6533c72

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyoichi-sugahara kyoichi-sugahara merged commit 341d35e into autowarefoundation:main Dec 12, 2023
41 of 43 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the feat/publish_mode_status branch December 12, 2023 09:25
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
…arefoundation#5845)

add publisher to publish auto mode status

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
rej55 pushed a commit to tier4/autoware.universe that referenced this pull request Dec 18, 2023
…arefoundation#5845)

add publisher to publish auto mode status

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Dec 18, 2023
…arefoundation#5845) (#1076)

add publisher to publish auto mode status

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…arefoundation#5845)

add publisher to publish auto mode status

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…arefoundation#5845)

add publisher to publish auto mode status

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…arefoundation#5845)

add publisher to publish auto mode status

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…arefoundation#5845)

add publisher to publish auto mode status

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…arefoundation#5845)

add publisher to publish auto mode status

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants