fix(goal_planner): fix checkOriginalGoalIsInShoulder #5836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satoshi-ota
approved these changes
Dec 11, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5836 +/- ##
=======================================
Coverage 15.27% 15.28%
=======================================
Files 1739 1739
Lines 119804 119792 -12
Branches 36373 36370 -3
=======================================
Hits 18305 18305
+ Misses 81024 81012 -12
Partials 20475 20475
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
e8d02de to
b11d5cc
Compare
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
…ion#5836) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
…ion#5836) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: karishma <karishma@interpl.ai>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
…ion#5836) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: karishma <karishma@interpl.ai>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
…ion#5836) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…ion#5836) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…ion#5836) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
checkOriginalGoalIsInShoulder must check original goal pose
and remove unused methods.
this fix #5533 (comment)
before
after
tier4 internal ticket
https://tier4.atlassian.net/browse/RT1-4666
Tests performed
psim
evaluator_description: fix/check_goal_is_in_shoulder
2023/12/11 https://evaluation.tier4.jp/evaluation/reports/11a68df2-9b57-500e-b5f2-56c687c126ea/?project_id=prd_jt
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.