Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(blind_spot_module): boost::optional to std::optional #5831

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 commented Dec 11, 2023

Description

🤖[deprecated] Generated by Copilot at 63b8624

This pull request modernizes the code of the behavior_velocity_blind_spot_module by replacing boost::optional with std::optional in scene.cpp and scene.hpp. This improves compatibility and performance, and removes the unnecessary dependency on libboost-dev in package.xml.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 11, 2023
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 11, 2023
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 changed the title refactor(blind_spot_module: boost::optional to std::optional refactor(blind_spot_module): boost::optional to std::optional Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (f41d3fa) 15.28% compared to head (63b8624) 15.28%.
Report is 2 commits behind head on main.

Files Patch % Lines
.../behavior_velocity_blind_spot_module/src/scene.cpp 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5831      +/-   ##
==========================================
- Coverage   15.28%   15.28%   -0.01%     
==========================================
  Files        1739     1739              
  Lines      119756   119763       +7     
  Branches    36369    36372       +3     
==========================================
  Hits        18301    18301              
- Misses      80976    80979       +3     
- Partials    20479    20483       +4     
Flag Coverage Δ *Carryforward flag
differential 14.22% <0.00%> (?)
total 15.28% <ø> (+<0.01%) ⬆️ Carriedforward from f41d3fa

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit c3dcd81 into autowarefoundation:main Dec 13, 2023
32 of 37 checks passed
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the refactor-blind-spot-optional-boost-to-std branch December 13, 2023 04:00
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
…refoundation#5831)

refactor(blind_spot_module: boost::optional to std::optional

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…refoundation#5831)

refactor(blind_spot_module: boost::optional to std::optional

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…refoundation#5831)

refactor(blind_spot_module: boost::optional to std::optional

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…refoundation#5831)

refactor(blind_spot_module: boost::optional to std::optional

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…refoundation#5831)

refactor(blind_spot_module: boost::optional to std::optional

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…refoundation#5831)

refactor(blind_spot_module: boost::optional to std::optional

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants