-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(blind_spot_module): boost::optional to std::optional #5831
Merged
zulfaqar-azmi-t4
merged 1 commit into
autowarefoundation:main
from
zulfaqar-azmi-t4:refactor-blind-spot-optional-boost-to-std
Dec 13, 2023
Merged
refactor(blind_spot_module): boost::optional to std::optional #5831
zulfaqar-azmi-t4
merged 1 commit into
autowarefoundation:main
from
zulfaqar-azmi-t4:refactor-blind-spot-optional-boost-to-std
Dec 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5831 +/- ##
==========================================
- Coverage 15.28% 15.28% -0.01%
==========================================
Files 1739 1739
Lines 119756 119763 +7
Branches 36369 36372 +3
==========================================
Hits 18301 18301
- Misses 80976 80979 +3
- Partials 20479 20483 +4
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
soblin
approved these changes
Dec 13, 2023
c3dcd81
into
autowarefoundation:main
32 of 37 checks passed
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
…refoundation#5831) refactor(blind_spot_module: boost::optional to std::optional Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
…refoundation#5831) refactor(blind_spot_module: boost::optional to std::optional Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: karishma <karishma@interpl.ai>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
…refoundation#5831) refactor(blind_spot_module: boost::optional to std::optional Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: karishma <karishma@interpl.ai>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
…refoundation#5831) refactor(blind_spot_module: boost::optional to std::optional Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…refoundation#5831) refactor(blind_spot_module: boost::optional to std::optional Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…refoundation#5831) refactor(blind_spot_module: boost::optional to std::optional Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🤖[deprecated] Generated by Copilot at 63b8624
This pull request modernizes the code of the behavior_velocity_blind_spot_module by replacing
boost::optional
withstd::optional
inscene.cpp
andscene.hpp
. This improves compatibility and performance, and removes the unnecessary dependency onlibboost-dev
inpackage.xml
.Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.