feat(system_diagnostic_graph): support config override and add tests #5816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5816 +/- ##
===========================================
+ Coverage 15.32% 39.71% +24.39%
===========================================
Files 1721 14 -1707
Lines 118559 637 -117922
Branches 37995 261 -37734
===========================================
- Hits 18169 253 -17916
+ Misses 79657 227 -79430
+ Partials 20733 157 -20576
☔ View full report in Codecov by Sentry. |
mkuri
approved these changes
Dec 8, 2023
5 tasks
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
…utowarefoundation#5816) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
…utowarefoundation#5816) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Signed-off-by: karishma <karishma@interpl.ai>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
…utowarefoundation#5816) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Signed-off-by: karishma <karishma@interpl.ai>
isamu-takagi
added a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 19, 2023
…utowarefoundation#5816) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
…utowarefoundation#5816) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…utowarefoundation#5816) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…utowarefoundation#5816) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related links
None
Tests performed
Notes for reviewers
You can see the structure of the graph with the following command.
Interface changes
None
Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.