Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection): ignore occlusion on amber color too #5693

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Nov 27, 2023

Description

ignore occlusion in the intersection when AMBER in addition to RED

Related links

Tests performed

At [00:18] the traffic light color changes to AMBER and the intersection_occlusion wall is canceled.

RT1-4540-2023-11-30_19.12.47.mp4

Notes for reviewers

none

Interface changes

none.

Effects on system behavior

none.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 27, 2023
@soblin soblin marked this pull request as ready for review November 30, 2023 08:29
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 30, 2023
@kyoichi-sugahara kyoichi-sugahara self-assigned this Nov 30, 2023
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (c5572dd) 5.37%.
Report is 118 commits behind head on main.

Files Patch % Lines
planning/behavior_velocity_planner/src/node.cpp 0.00% 0 Missing and 5 partials ⚠️
...ity_intersection_module/src/scene_intersection.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #5693       +/-   ##
==========================================
- Coverage   15.32%   5.37%    -9.95%     
==========================================
  Files        1721      11     -1710     
  Lines      118559    2492   -116067     
  Branches    37995    1491    -36504     
==========================================
- Hits        18169     134    -18035     
+ Misses      79657    2049    -77608     
+ Partials    20733     309    -20424     
Flag Coverage Δ
differential 5.37% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit 85656ce into autowarefoundation:main Dec 1, 2023
15 of 18 checks passed
@soblin soblin deleted the feat/intersection/amber-ignore-occlusion branch December 1, 2023 00:43
soblin added a commit to tier4/autoware.universe that referenced this pull request Dec 1, 2023
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request Dec 1, 2023
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants