Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ar_tag_based_localizer): organized the order of the process #5692

Conversation

SakodaShintaro
Copy link
Contributor

@SakodaShintaro SakodaShintaro commented Nov 27, 2023

Description

Refactored to match the order of processing with general landmark-based self-location estimation.

The code has been changed to do the following in the following order

(1) Detect all markers
(2) Calculate a new self pose

Tests performed

Using the following data, it has been confirmed that the ar_tag_based_localizer runs with approximately the same accuracy as before.

https://github.com/autowarefoundation/autoware.universe/tree/d99e56b3968d01233c0367a824dac154154beb9c/localization/landmark_based_localizer/ar_tag_based_localizer#rosbag

Effects on system behavior

There is no effects on system behavior.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
@SakodaShintaro SakodaShintaro self-assigned this Nov 27, 2023
@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Nov 27, 2023
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
@SakodaShintaro SakodaShintaro added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 27, 2023
@SakodaShintaro SakodaShintaro marked this pull request as ready for review November 27, 2023 09:36
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 113 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (a31ca33) 7.42%.
Report is 78 commits behind head on main.

Files Patch % Lines
...tag_based_localizer/src/ar_tag_based_localizer.cpp 0.00% 109 Missing and 2 partials ⚠️
...sed_localizer/ar_tag_based_localizer/test/test.cpp 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #5692       +/-   ##
==========================================
- Coverage   15.32%   7.42%    -7.91%     
==========================================
  Files        1721       3     -1718     
  Lines      118559     229   -118330     
  Branches    37995     137    -37858     
==========================================
- Hits        18169      17    -18152     
+ Misses      79657     166    -79491     
+ Partials    20733      46    -20687     
Flag Coverage Δ
differential 7.42% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SakodaShintaro SakodaShintaro merged commit 3dc46d0 into autowarefoundation:main Nov 27, 2023
@SakodaShintaro SakodaShintaro deleted the refactor/ar_tag_based_localizer_20231124 branch November 27, 2023 23:49
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
…utowarefoundation#5692)

* Refactored ar_tag_based_localizer

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Restored ekf input

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Refactored convert process

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Fixed cv_ptr

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Restored README.md

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Fixed as noted by linter

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

---------

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants