-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ar_tag_based_localizer): organized the order of the process #5692
Merged
SakodaShintaro
merged 7 commits into
autowarefoundation:main
from
SakodaShintaro:refactor/ar_tag_based_localizer_20231124
Nov 27, 2023
Merged
refactor(ar_tag_based_localizer): organized the order of the process #5692
SakodaShintaro
merged 7 commits into
autowarefoundation:main
from
SakodaShintaro:refactor/ar_tag_based_localizer_20231124
Nov 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5692 +/- ##
==========================================
- Coverage 15.32% 7.42% -7.91%
==========================================
Files 1721 3 -1718
Lines 118559 229 -118330
Branches 37995 137 -37858
==========================================
- Hits 18169 17 -18152
+ Misses 79657 166 -79491
+ Partials 20733 46 -20687
☔ View full report in Codecov by Sentry. |
YamatoAndo
approved these changes
Nov 27, 2023
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
…utowarefoundation#5692) * Refactored ar_tag_based_localizer Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Restored ekf input Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Refactored convert process Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Fixed cv_ptr Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Restored README.md Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Fixed as noted by linter Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> --------- Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:localization
Vehicle's position determination in its environment. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored to match the order of processing with general landmark-based self-location estimation.
The code has been changed to do the following in the following order
(1) Detect all markers
(2) Calculate a new self pose
Tests performed
Using the following data, it has been confirmed that the
ar_tag_based_localizer
runs with approximately the same accuracy as before.https://github.com/autowarefoundation/autoware.universe/tree/d99e56b3968d01233c0367a824dac154154beb9c/localization/landmark_based_localizer/ar_tag_based_localizer#rosbag
Effects on system behavior
There is no effects on system behavior.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.