Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ekf_localizer): correct the calculation of delay_step in updateMeasurementPose/Twist #5691

Merged

Merge branch 'main' into fix/correct_ekf_delay_step

89b85b7
Select commit
Loading
Failed to load commit list.
Merged

fix(ekf_localizer): correct the calculation of delay_step in updateMeasurementPose/Twist #5691

Merge branch 'main' into fix/correct_ekf_delay_step
89b85b7
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Dec 6, 2023 in 1m 2s

CodeScene PR Check

Code Health Quality Gates: FAILED

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Bumpy Road Ahead ekf_localizer.cpp: EKFLocalizer::updatePredictFrequency

Annotations

Check warning on line 126 in localization/ekf_localizer/src/ekf_localizer.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

EKFLocalizer::updatePredictFrequency has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.