refactor(sensing-vehicle-velocity-converter): rework parameters #5609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b640972 to
a202acb
Compare
satoshi-ota
reviewed
Nov 23, 2023
| speed_scale_factor_ = declare_parameter("speed_scale_factor", 1.0); | ||
| stddev_vx_ = declare_parameter<double>("velocity_stddev_xx"); | ||
| stddev_wz_ = declare_parameter<double>("angular_velocity_stddev_zz"); | ||
| frame_id_ = declare_parameter<string>("frame_id"); |
There was a problem hiding this comment.
Suggested change
| frame_id_ = declare_parameter<string>("frame_id"); | |
| frame_id_ = declare_parameter<std::string>("frame_id"); |
auto-merge was automatically disabled
November 23, 2023 05:49
Head branch was pushed to by a user without write access
40470e7 to
3f6bb83
Compare
Signed-off-by: karishma <karishma@interpl.ai>
Signed-off-by: karishma <karishma@interpl.ai>
3f6bb83 to
78c7504
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5609 +/- ##
==========================================
- Coverage 15.32% 0.00% -15.33%
==========================================
Files 1721 3 -1718
Lines 118559 30 -118529
Branches 37995 0 -37995
==========================================
- Hits 18169 0 -18169
+ Misses 79657 30 -79627
+ Partials 20733 0 -20733
☔ View full report in Codecov by Sentry. |
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
…warefoundation#5609) * sensing-vehicle-velocity-converter-module Signed-off-by: karishma <karishma@interpl.ai> * sensing-vehicle-velocity-converter Signed-off-by: karishma <karishma@interpl.ai> --------- Signed-off-by: karishma <karishma@interpl.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the vehicle_velocity_converter package.
Tests performed
Not applicable.
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.