-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(lidar_centerpoint): add training docs #5570
Merged
xmfcx
merged 16 commits into
autowarefoundation:main
from
kaancolak:refactor/lidar_centerpoint-add-training-docs
Jun 13, 2024
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
6ea3577
refactor(lidar_centerpoint): add training docs
kaancolak 20ef77c
style(pre-commit): autofix
pre-commit-ci[bot] 48afb5c
refactor(lidar_centerpoint): and link and small fix
kaancolak 06ab87b
refactor(lidar_centerpoint): update docs.
kaancolak b7d671a
fix(lidar_centerpoint): change dataset name
kaancolak 808a7c7
fix(lidar_centerpoint): add docker instruction
kaancolak 3345fd8
style(pre-commit): autofix
pre-commit-ci[bot] 2f780bd
fix(lidar_centerpoint): fix spell
kaancolak ef15632
small fixes and spellcheck
983c800
Merge branch 'main' into refactor/lidar_centerpoint-add-training-docs
kaancolak b3b609a
docs(lidar_centerpoint): add version
kaancolak 8475055
Merge branch 'main' into refactor/lidar_centerpoint-add-training-docs
kaancolak e3f7194
Update README.md
kaancolak 26f028c
docs(lidar_centerpoint): add link
kaancolak b0fad69
Merge branch 'main' into refactor/lidar_centerpoint-add-training-docs
kaancolak bb2a69e
Merge branch 'main' into refactor/lidar_centerpoint-add-training-docs
kaancolak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaancolak
Can you add dockerfile to make this environment in https://github.com/autowarefoundation/mmdetection3d.git?
We can make installation step shorter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shin-kyoto -san, thank you for your advice!
Updated the current docker file with these installation steps.
https://github.com/autowarefoundation/mmdetection3d/pull/1/files#diff-f34da55ca08f1a30591d8b0b3e885bcc678537b2a9a4aadea4f190806b374ddcL1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaancolak
Thank you so much!! Can you update this document to align with the environment setup procedures using Docker?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shin-kyoto sure, I added instructions to here:
https://github.com/autowarefoundation/autoware.universe/pull/5570/files#diff-ef509aa43435872925d0134c14c088da6f51549d59e84cc5bd3e74fd4fa333f9R134