-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(objects_of_interest_marker_interface): add objects of interest marker interface #5564
Merged
rej55
merged 12 commits into
autowarefoundation:main
from
rej55:feat/interest_objects_visualization
Nov 24, 2023
Merged
feat(objects_of_interest_marker_interface): add objects of interest marker interface #5564
rej55
merged 12 commits into
autowarefoundation:main
from
rej55:feat/interest_objects_visualization
Nov 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2dea793
to
e09fc98
Compare
a85f02d
to
1172566
Compare
kosuke55
reviewed
Nov 24, 2023
...interest_objects_marker_interface/include/interest_objects_marker_interface/marker_utils.hpp
Outdated
Show resolved
Hide resolved
planning/interest_objects_marker_interface/src/interest_objects_marker_interface.cpp
Outdated
Show resolved
Hide resolved
...er_interface/include/interest_objects_marker_interface/interest_objects_marker_interface.hpp
Outdated
Show resolved
Hide resolved
...er_interface/include/interest_objects_marker_interface/interest_objects_marker_interface.hpp
Outdated
Show resolved
Hide resolved
…interface Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
…tions Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
14cd394
to
1d5545f
Compare
kosuke55
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! thanks!!
rej55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 29, 2023
…arker interface (autowarefoundation#5564) * feat(interest_objects_marker_interface): add interest objects marker interface Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * feat(interest_objects_marker_interface): change marker type Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * feat(interest_objects_marker_interface): change markers Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * feat(interest_objects_marker_interface): fix lane change interface Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * feat(interest_objects_marker_interface): fix interface Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * refactor(interest_objects_marker_interface): fix interface Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * refactor(interest_objects_marker_interface): refactor and add descriptions Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * refactor(lane_change): refactor Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * docs(interest_objects_visualization): add contents (under construction) Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * chore(interest_objects_visualization): fix includes and package.xml Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * fix(interest_objects_marker_interface): fix Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * refactor(objects_of_interest_marker_interface): rename interface Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> --------- Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
7 tasks
kyoichi-sugahara
added a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Dec 13, 2023
…terest marker interface (autowarefoundation#5564)" This reverts commit c1c9098.
kyoichi-sugahara
added a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 13, 2023
…terest marker interface (autowarefoundation#5564)" Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
7 tasks
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
…arker interface (autowarefoundation#5564) * feat(interest_objects_marker_interface): add interest objects marker interface Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * feat(interest_objects_marker_interface): change marker type Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * feat(interest_objects_marker_interface): change markers Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * feat(interest_objects_marker_interface): fix lane change interface Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * feat(interest_objects_marker_interface): fix interface Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * refactor(interest_objects_marker_interface): fix interface Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * refactor(interest_objects_marker_interface): refactor and add descriptions Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * refactor(lane_change): refactor Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * docs(interest_objects_visualization): add contents (under construction) Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * chore(interest_objects_visualization): fix includes and package.xml Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * fix(interest_objects_marker_interface): fix Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * refactor(objects_of_interest_marker_interface): rename interface Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> --------- Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To visualize what objects planning modules interest, I add an interface to visualize interest objects.
Furthermore, I apply this interface to lane change module temporary.
Applying to other modules and commonalize is future work.
File structure:
planning/interest_objects_marker_interface
include
coloring.hpp
interest_objects_marker_interface.hpp
marker_data.hpp
marker_utils.hpp
src
coloring.cpp
interest_objects_marker_interface.cpp
marker_data.cpp
marker_utils.cpp
CMakeLists.txt
package.xml
README.md
Related links
Tests performed
TIER IV INTERNAL TEST
Tested in planning simulator.
Screencast.from.2023.11.21.17.19.17.webm
Notes for reviewers
Interface changes
Topics for visualizing interest objects are added.
In this PR, lane change module is only added.
Effects on system behavior
We can view the interest objects for planning modules.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.