-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(probabilistic_occupancy_grid_map): add synchronized ogm fusion node #5485
feat(probabilistic_occupancy_grid_map): add synchronized ogm fusion node #5485
Conversation
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
It seems launch_test for grid map fusion is not working well. Please wait for awhile. |
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
…_lidar ogm creation Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: Yoshi, Ri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: Yoshi, Ri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5485 +/- ##
==========================================
- Coverage 14.80% 14.77% -0.03%
==========================================
Files 1915 1917 +2
Lines 132241 131656 -585
Branches 39318 39074 -244
==========================================
- Hits 19574 19452 -122
+ Misses 90835 90488 -347
+ Partials 21832 21716 -116
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Additional check for OGMThere are about 2~5ms latency with OGM fusion.
|
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
…' into feat/rearrange_grid_map_fusion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
…ode (autowarefoundation#5485) * add synchronized ogm fusion node Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * add launch test for grid map fusion node Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix test cases input msg error Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * change default fusion parameter Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * rename parameter for ogm fusion Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * feat: add multi_lidar_ogm generation method Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * enable ogm creation launcher in tier4_perception_launch to call multi_lidar ogm creation Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix: change ogm fusion node pub policy to reliable Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix: fix to use lidar frame as scan frame Signed-off-by: Yoshi, Ri <yoshiyoshidetteiu@gmail.com> * fix: launcher node Signed-off-by: Yoshi, Ri <yoshiyoshidetteiu@gmail.com> * feat: update param name Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * chore: fix ogm pointcloud subscription Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * feat: enable to publish pipeline latency Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> Signed-off-by: Yoshi, Ri <yoshiyoshidetteiu@gmail.com>
…ode (autowarefoundation#5485) * add synchronized ogm fusion node Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * add launch test for grid map fusion node Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix test cases input msg error Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * change default fusion parameter Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * rename parameter for ogm fusion Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * feat: add multi_lidar_ogm generation method Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * enable ogm creation launcher in tier4_perception_launch to call multi_lidar ogm creation Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix: change ogm fusion node pub policy to reliable Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix: fix to use lidar frame as scan frame Signed-off-by: Yoshi, Ri <yoshiyoshidetteiu@gmail.com> * fix: launcher node Signed-off-by: Yoshi, Ri <yoshiyoshidetteiu@gmail.com> * feat: update param name Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * chore: fix ogm pointcloud subscription Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * feat: enable to publish pipeline latency Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> Signed-off-by: Yoshi, Ri <yoshiyoshidetteiu@gmail.com>
…ode (autowarefoundation#5485) * add synchronized ogm fusion node Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * add launch test for grid map fusion node Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix test cases input msg error Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * change default fusion parameter Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * rename parameter for ogm fusion Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * feat: add multi_lidar_ogm generation method Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * enable ogm creation launcher in tier4_perception_launch to call multi_lidar ogm creation Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix: change ogm fusion node pub policy to reliable Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix: fix to use lidar frame as scan frame Signed-off-by: Yoshi, Ri <yoshiyoshidetteiu@gmail.com> * fix: launcher node Signed-off-by: Yoshi, Ri <yoshiyoshidetteiu@gmail.com> * feat: update param name Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * chore: fix ogm pointcloud subscription Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * feat: enable to publish pipeline latency Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> Signed-off-by: Yoshi, Ri <yoshiyoshidetteiu@gmail.com>
…ode (autowarefoundation#5485) * add synchronized ogm fusion node Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * add launch test for grid map fusion node Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix test cases input msg error Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * change default fusion parameter Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * rename parameter for ogm fusion Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * feat: add multi_lidar_ogm generation method Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * enable ogm creation launcher in tier4_perception_launch to call multi_lidar ogm creation Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix: change ogm fusion node pub policy to reliable Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix: fix to use lidar frame as scan frame Signed-off-by: Yoshi, Ri <yoshiyoshidetteiu@gmail.com> * fix: launcher node Signed-off-by: Yoshi, Ri <yoshiyoshidetteiu@gmail.com> * feat: update param name Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * chore: fix ogm pointcloud subscription Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * feat: enable to publish pipeline latency Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> Signed-off-by: Yoshi, Ri <yoshiyoshidetteiu@gmail.com> Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
…ode (autowarefoundation#5485) * add synchronized ogm fusion node Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * add launch test for grid map fusion node Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix test cases input msg error Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * change default fusion parameter Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * rename parameter for ogm fusion Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * feat: add multi_lidar_ogm generation method Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * enable ogm creation launcher in tier4_perception_launch to call multi_lidar ogm creation Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix: change ogm fusion node pub policy to reliable Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix: fix to use lidar frame as scan frame Signed-off-by: Yoshi, Ri <yoshiyoshidetteiu@gmail.com> * fix: launcher node Signed-off-by: Yoshi, Ri <yoshiyoshidetteiu@gmail.com> * feat: update param name Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * chore: fix ogm pointcloud subscription Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * feat: enable to publish pipeline latency Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> Signed-off-by: Yoshi, Ri <yoshiyoshidetteiu@gmail.com>
Description
This PR aiming to rearrange #3107.
It enables to run occupancy grid map with multi lidar frame.
Related links
Related PR needed for test
Tests performed
Tested in gtest and lsim.
In the sample rosbag,
latency comparison
Notes for reviewers
Please be sure all of following changes are merged in your repository.
Related PR needed for test
And then, set
occupancy_grid_map_method
in tier4_perception_component.launch.xml tomulti_lidar_pointcloud_based_occupancy_grid_map
.Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.
Summary by CodeRabbit