-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(simple_planning_simulator): add steer dead band #5477
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5477 +/- ##
=======================================
Coverage 14.84% 14.85%
=======================================
Files 1665 1665
Lines 116233 116248 +15
Branches 36257 36264 +7
=======================================
+ Hits 17257 17270 +13
+ Misses 79475 79474 -1
- Partials 19501 19504 +3
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
6da8149
to
bc21a8f
Compare
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
bc21a8f
to
81a6047
Compare
...r/simple_planning_simulator/src/simple_planning_simulator/simple_planning_simulator_core.cpp
Outdated
Show resolved
Hide resolved
…tor/simple_planning_simulator_core.cpp Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
…ion#5477) * feat(simple_planning_simulator): add steer dead band Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Update simulator/simple_planning_simulator/src/simple_planning_simulator/simple_planning_simulator_core.cpp Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Update simulator/simple_planning_simulator/README.md Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update params Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
…ion#5477) * feat(simple_planning_simulator): add steer dead band Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Update simulator/simple_planning_simulator/src/simple_planning_simulator/simple_planning_simulator_core.cpp Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Update simulator/simple_planning_simulator/README.md Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update params Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
* feat(simple_planning_simulator): add steer dead band Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Update simulator/simple_planning_simulator/src/simple_planning_simulator/simple_planning_simulator_core.cpp Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Update simulator/simple_planning_simulator/README.md Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update params Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Description
add steer dead band to simulate actual vehicle
before
after
Related links
Tests performed
psim
evaluator_description: feat/steer_dead_band_sim
2023/11/03 https://evaluation.tier4.jp/evaluation/reports/d0fde7a0-2138-52e5-be7e-e175d48b776f/?project_id=prd_jt
Notes for reviewers
Interface changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.