Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(simple_planning_simulator): add steer dead band #5477

Merged
merged 4 commits into from
Nov 4, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Nov 2, 2023

Description

add steer dead band to simulate actual vehicle

before

image

after

image

Related links

Tests performed

psim

evaluator_description: feat/steer_dead_band_sim
2023/11/03 https://evaluation.tier4.jp/evaluation/reports/d0fde7a0-2138-52e5-be7e-e175d48b776f/?project_id=prd_jt

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (b56c721) 14.84% compared to head (9e4b2a7) 14.85%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5477   +/-   ##
=======================================
  Coverage   14.84%   14.85%           
=======================================
  Files        1665     1665           
  Lines      116233   116248   +15     
  Branches    36257    36264    +7     
=======================================
+ Hits        17257    17270   +13     
+ Misses      79475    79474    -1     
- Partials    19501    19504    +3     
Flag Coverage Δ *Carryforward flag
differential 57.94% <72.41%> (?)
total 14.84% <ø> (-0.01%) ⬇️ Carriedforward from 801278a

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...ulator/vehicle_model/sim_model_delay_steer_acc.hpp 100.00% <ø> (ø)
...vehicle_model/sim_model_delay_steer_acc_geared.hpp 100.00% <ø> (ø)
...ulator/vehicle_model/sim_model_delay_steer_vel.hpp 100.00% <ø> (ø)
...nning_simulator/simple_planning_simulator_core.cpp 37.53% <0.00%> (-0.10%) ⬇️
...ulator/vehicle_model/sim_model_delay_steer_acc.cpp 80.55% <77.77%> (+1.45%) ⬆️
...vehicle_model/sim_model_delay_steer_acc_geared.cpp 80.64% <77.77%> (+1.09%) ⬆️
...ulator/vehicle_model/sim_model_delay_steer_vel.cpp 82.43% <70.00%> (+1.00%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 force-pushed the feat/steer_dead_band_sim branch from 6da8149 to bc21a8f Compare November 3, 2023 01:45
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the feat/steer_dead_band_sim branch from bc21a8f to 81a6047 Compare November 3, 2023 02:04
kosuke55 and others added 3 commits November 3, 2023 15:13
…tor/simple_planning_simulator_core.cpp

Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@TakaHoribe TakaHoribe self-requested a review November 3, 2023 08:15
Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@xmfcx xmfcx added type:documentation Creating or refining documentation. (auto-assigned) and removed component:documentation labels Nov 3, 2023
@kosuke55 kosuke55 added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Nov 4, 2023
@kosuke55 kosuke55 merged commit e1e9f57 into main Nov 4, 2023
@kosuke55 kosuke55 deleted the feat/steer_dead_band_sim branch November 4, 2023 11:10
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Nov 7, 2023
…ion#5477)

* feat(simple_planning_simulator): add steer dead band

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update simulator/simple_planning_simulator/src/simple_planning_simulator/simple_planning_simulator_core.cpp

Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Update simulator/simple_planning_simulator/README.md

Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* update params

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Nov 9, 2023
…ion#5477)

* feat(simple_planning_simulator): add steer dead band

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update simulator/simple_planning_simulator/src/simple_planning_simulator/simple_planning_simulator_core.cpp

Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Update simulator/simple_planning_simulator/README.md

Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* update params

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
kosuke55 added a commit that referenced this pull request Dec 14, 2023
* feat(simple_planning_simulator): add steer dead band

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update simulator/simple_planning_simulator/src/simple_planning_simulator/simple_planning_simulator_core.cpp

Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Update simulator/simple_planning_simulator/README.md

Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* update params

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:simulation Virtual environment setups and simulations. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants