Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(system_diagnostic_graph): unify units and add file path substitution #5447

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Oct 31, 2023

Description

Unify units and add file path substitution.

Related links

None

Tests performed

colcon test --packages-select system_diagnostic_graph --event-handlers console_cohesion+

Notes for reviewers

None

Interface changes

None

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi isamu-takagi self-assigned this Oct 31, 2023
@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Oct 31, 2023
@isamu-takagi isamu-takagi added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 31, 2023
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 210 lines in your changes are missing coverage. Please review.

Comparison is base (1998880) 14.71% compared to head (d0e47c9) 14.81%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5447      +/-   ##
==========================================
+ Coverage   14.71%   14.81%   +0.10%     
==========================================
  Files        1665     1669       +4     
  Lines      116209   116370     +161     
  Branches    36027    36237     +210     
==========================================
+ Hits        17105    17246     +141     
+ Misses      79720    79633      -87     
- Partials    19384    19491     +107     
Flag Coverage Δ *Carryforward flag
differential 29.07% <35.58%> (?)
total 14.74% <ø> (+0.02%) ⬆️ Carriedforward from 5ed8e25

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
system/system_diagnostic_graph/src/main.cpp 0.00% <0.00%> (ø)
system/system_diagnostic_graph/src/core/debug.cpp 0.00% <0.00%> (ø)
system/system_diagnostic_graph/src/core/modes.cpp 0.00% <0.00%> (ø)
system/system_diagnostic_graph/src/core/config.hpp 33.33% <33.33%> (+33.33%) ⬆️
system/system_diagnostic_graph/src/core/error.hpp 0.00% <0.00%> (ø)
system/system_diagnostic_graph/src/core/units.hpp 9.09% <9.09%> (ø)
system/system_diagnostic_graph/test/src/test.cpp 73.80% <73.80%> (ø)
system/system_diagnostic_graph/src/core/graph.cpp 18.88% <14.03%> (+18.88%) ⬆️
system/system_diagnostic_graph/src/core/config.cpp 51.02% <51.75%> (+51.02%) ⬆️
system/system_diagnostic_graph/src/core/units.cpp 17.80% <17.80%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isamu-takagi isamu-takagi requested a review from mkuri October 31, 2023 07:23
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@mkuri mkuri self-requested a review November 1, 2023 10:52
Copy link
Contributor

@mkuri mkuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isamu-takagi isamu-takagi merged commit 64e2ab3 into autowarefoundation:main Nov 1, 2023
@isamu-takagi isamu-takagi deleted the feat/system-diagnostic-graph-3 branch November 2, 2023 01:26
isamu-takagi added a commit to tier4/autoware.universe that referenced this pull request Nov 30, 2023
…tion (autowarefoundation#5447)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants