fix(lane_change): separate backward buffer for blocking object #5434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
This was referenced Oct 27, 2023
kosuke55
reviewed
Oct 27, 2023
Comment on lines
271
to
273
| const auto stopping_distance_for_obj = | ||
| distance_to_ego_lane_obj - lane_change_buffer_for_blocking_object - stop_point_buffer - | ||
| rss_dist - getCommonParam().base_link2front; |
There was a problem hiding this comment.
const double stop_point_buffer = getCommonParam().backward_length_buffer_for_end_of_lane;
is as intended?
kosuke55
reviewed
Oct 27, 2023
planning/behavior_path_planner/src/scene_module/lane_change/normal.cpp
Outdated
Show resolved
Hide resolved
kosuke55
approved these changes
Oct 27, 2023
…rmal.cpp Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5434 +/- ##
==========================================
- Coverage 15.07% 15.06% -0.01%
==========================================
Files 1662 1662
Lines 115724 115737 +13
Branches 35753 35761 +8
==========================================
Hits 17441 17441
- Misses 78749 78760 +11
- Partials 19534 19536 +2
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Nov 1, 2023
…arefoundation#5434) * fix(lane_change): separate backward buffer for blocking object Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * Update planning/behavior_path_planner/src/scene_module/lane_change/normal.cpp Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com> * style(pre-commit): autofix --------- Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Separate backward buffer parameter for blocking object
Merge this PR first autowarefoundation/autoware_launch#661
Related links
Tests performed
TIER IV INTERNAL TEST
Notes for reviewers
Interface changes
backward_length_buffer_for_blocking_objectis added.Effects on system behavior
Able to change backward length buffer for blocking object.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.