Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spell-check): add dltype and tvmgen to local dict #5420

Conversation

lexavtanke
Copy link
Contributor

@lexavtanke lexavtanke commented Oct 26, 2023

Description

As @HansRobo suggested in tier4/autoware-spell-check-dict#631 (comment) I added words dltype and tvmgen to local dict. It is expected that in the future It will suppress spell-check warnings from json model files generated by tvm_cli.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

lexavtanke and others added 2 commits October 26, 2023 12:55
@lexavtanke lexavtanke requested a review from HansRobo October 26, 2023 12:17
@lexavtanke lexavtanke marked this pull request as ready for review October 26, 2023 12:17
@HansRobo
Copy link
Member

Same changes were merged in #4923.
Thank you!

@HansRobo HansRobo closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants