refactor(landmark_based_localizer): refactored landmark_tf_caster #5414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
YamatoAndo
reviewed
Oct 26, 2023
| <license>Apache License 2.0</license> | ||
|
|
||
| <buildtool_depend>ament_cmake</buildtool_depend> | ||
| <buildtool_depend>autoware_cmake</buildtool_depend> | ||
|
|
||
| <depend>autoware_auto_mapping_msgs</depend> | ||
| <depend>eigen</depend> |
There was a problem hiding this comment.
Suggested change
| <depend>eigen</depend> | |
| <build_depend>eigen</build_depend> |
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5414 +/- ##
==========================================
- Coverage 14.75% 14.74% -0.02%
==========================================
Files 1661 1662 +1
Lines 115525 115612 +87
Branches 35670 35670
==========================================
Hits 17050 17050
- Misses 79231 79318 +87
Partials 19244 19244
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
YamatoAndo
approved these changes
Oct 26, 2023
|
@SakodaShintaro In my environment, some landmarks does not appear in rviz. Do you know what is causing it? |
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
|
⬆️ now I understand the cause. |
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
|
@KYabuuchi |
KYabuuchi
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
landmark_tf_casternode, and modified the package as a library providing parsing functions.landmark_tf_castertolandmark_parser/tf_static, but is held by each landmark_based_localizer as astd::map<std::string, geometry_msgs::msg::Pose>.autoware_auto_mapping_msgs::msg::HADMapBinis also performed by each landmark based localizer.~/debug/markerTests performed
The AR tag based localizer is confirmed to work properly.
Effects on system behavior
There is no change in the behavior on the system as a whole.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.