Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(avoidance): add use_conservative_buffer_longitudinal #5405

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Oct 25, 2023

Description

Added a parameter of use_conservative_buffer_longitudinal.

  • When set to true,
    • the base_link2front is added to the longitudinal buffer before avoidance to be comparatively conservative against the distance to the object.
  • When set to false,
    • the base_link2front is NOT added to the longitudinal buffer before avoidance to be comparatively aggressive against the distance to the object.

Tests performed

psim
unit test

Effects on system behavior

No behavior change by default

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 25, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review October 25, 2023 07:04
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 25, 2023
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 133 lines in your changes are missing coverage. Please review.

Comparison is base (f400b91) 14.80% compared to head (438d5ec) 14.80%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5405   +/-   ##
=======================================
  Coverage   14.80%   14.80%           
=======================================
  Files        1661     1661           
  Lines      115453   115482   +29     
  Branches    35644    35650    +6     
=======================================
+ Hits        17093    17098    +5     
- Misses      79114    79132   +18     
- Partials    19246    19252    +6     
Flag Coverage Δ *Carryforward flag
differential 12.34% <7.63%> (?)
total 14.81% <ø> (+<0.01%) ⬆️ Carriedforward from f400b91

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...motion_utils/src/vehicle/vehicle_state_checker.cpp 72.54% <ø> (-1.04%) ⬇️
...et2_map_loader/lanelet2_map_visualization_node.cpp 0.00% <ø> (ø)
..._planner/utils/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...ehavior_velocity_intersection_module/src/debug.cpp 0.00% <ø> (ø)
...avior_velocity_intersection_module/src/manager.cpp 14.33% <ø> (ø)
...ity_intersection_module/src/scene_intersection.cpp 0.00% <ø> (ø)
...ity_intersection_module/src/scene_intersection.hpp 0.00% <ø> (ø)
...behavior_velocity_intersection_module/src/util.cpp 0.00% <ø> (ø)
...ior_velocity_intersection_module/src/util_type.hpp 0.00% <ø> (ø)
...cene_module/start_planner/start_planner_module.hpp 0.00% <0.00%> (ø)
... and 8 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 merged commit d6be0d2 into autowarefoundation:main Oct 25, 2023
@takayuki5168 takayuki5168 deleted the feat/avoidance-conservative-buffer-main branch October 25, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants