-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(avoidance): discard envelope polygon if the objects move long distance #5388
Merged
satoshi-ota
merged 3 commits into
autowarefoundation:main
from
satoshi-ota:feat/update-envelope-polygon
Oct 31, 2023
Merged
fix(avoidance): discard envelope polygon if the objects move long distance #5388
satoshi-ota
merged 3 commits into
autowarefoundation:main
from
satoshi-ota:feat/update-envelope-polygon
Oct 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tance Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
a06110d
to
bde24c1
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5388 +/- ##
==========================================
+ Coverage 14.75% 14.81% +0.05%
==========================================
Files 1661 1661
Lines 115525 117493 +1968
Branches 35671 37164 +1493
==========================================
+ Hits 17047 17401 +354
- Misses 79231 80503 +1272
- Partials 19247 19589 +342
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
kyoichi-sugahara
approved these changes
Oct 31, 2023
Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
kyoichi-sugahara
added a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Nov 1, 2023
…tance (autowarefoundation#5388) * fix(avoidance): discard envelope polygon if the objects move long distance Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * Update planning/behavior_path_planner/src/utils/avoidance/utils.cpp Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp> * Update planning/behavior_path_planner/src/utils/avoidance/utils.cpp Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 14, 2023
…tance (autowarefoundation#5388) * fix(avoidance): discard envelope polygon if the objects move long distance Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * Update planning/behavior_path_planner/src/utils/avoidance/utils.cpp Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp> * Update planning/behavior_path_planner/src/utils/avoidance/utils.cpp Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
4 tasks
shmpwk
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 14, 2023
…tance (autowarefoundation#5388) (#1013) * fix(avoidance): discard envelope polygon if the objects move long distance * Update planning/behavior_path_planner/src/utils/avoidance/utils.cpp * Update planning/behavior_path_planner/src/utils/avoidance/utils.cpp --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🤖 Generated by Copilot at a06110d
Improved object avoidance logic in
behavior_path_planner
by using a different envelope polygon function for large motion changes. Renamed and updatedutils.cpp
accordingly.Before this PR:
The envelope polygon continues to expand while the object is detected as target even if the object moves a few meter. This may cause unnecessary avoidance maneuver.
simplescreenrecorder-2023-10-25_18.59.56.mp4
After this PR:
The envelope polygon is reset if the latest envelope polygon is larger than threshold.
simplescreenrecorder-2023-10-25_18.52.30.mp4
Tests performed
Effects on system behavior
Improve avoidance maneuver.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.