-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(goal_planner): change debug polygons to contain the nominal margin #5365
fix(goal_planner): change debug polygons to contain the nominal margin #5365
Conversation
… some refactoring Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5365 +/- ##
=======================================
Coverage 14.76% 14.77%
=======================================
Files 1662 1662
Lines 115457 115374 -83
Branches 35639 35591 -48
=======================================
- Hits 17047 17043 -4
+ Misses 79181 79110 -71
+ Partials 19229 19221 -8
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!! LGTM
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Description
The polygons that are visualized were made identical to the polygons which the collision determination is actually performed.
In addition, a function with many arguments was removed.
Tests performed
psim test was perfomed.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.