Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(shape_estimation): rework parameters #5330

Conversation

PhoebeWu21
Copy link
Member

@PhoebeWu21 PhoebeWu21 commented Oct 17, 2023

Description

Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the shape_estimation package.

  • Remove the default value from the source code in order to ensure all parameter values are passed from the parameter files.
  • Create the schema

Tests performed

Package built and launch locally.
colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to shape_estimation

Effects on system behavior

More reliable and faster parameter configuration file creation.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Oct 17, 2023
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR 👍
LGTM

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Sorry, I forgot to approve because I thought it's enough with Saito-san's approve.

Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please confirm if the node can be launched after the changes?

@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (aad2e24) 0.00%.
Report is 107 commits behind head on main.

Files Patch % Lines
perception/shape_estimation/src/node.cpp 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #5330       +/-   ##
==========================================
- Coverage   15.32%   0.00%   -15.33%     
==========================================
  Files        1721      36     -1685     
  Lines      118559     689   -117870     
  Branches    37995       0    -37995     
==========================================
- Hits        18169       0    -18169     
+ Misses      79657     689    -78968     
+ Partials    20733       0    -20733     
Flag Coverage Δ
differential 0.00% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota
Copy link
Contributor

@miursh cc @PhoebeWu21 Could you review again...?

Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Sorry for the late response.

@miursh miursh merged commit 08a02ba into autowarefoundation:main Jan 12, 2024
13 of 16 checks passed
@PhoebeWu21 PhoebeWu21 deleted the refactor-node-config-shape_estimation branch February 7, 2024 00:35
badai-nguyen pushed a commit to tier4/autoware.universe that referenced this pull request Mar 19, 2024
* refactor(shape_estimation): rework parameters

Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>

* style(pre-commit): autofix

* refactor(shape_estimation): rework parameters

Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>

* refactor(shape_estimation): rework parameters

Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>

---------

Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
* refactor(shape_estimation): rework parameters

Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>

* style(pre-commit): autofix

* refactor(shape_estimation): rework parameters

Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>

* refactor(shape_estimation): rework parameters

Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>

---------

Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
* refactor(shape_estimation): rework parameters

Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>

* style(pre-commit): autofix

* refactor(shape_estimation): rework parameters

Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>

* refactor(shape_estimation): rework parameters

Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>

---------

Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
* refactor(shape_estimation): rework parameters

Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>

* style(pre-commit): autofix

* refactor(shape_estimation): rework parameters

Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>

* refactor(shape_estimation): rework parameters

Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>

---------

Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
* refactor(shape_estimation): rework parameters

Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>

* style(pre-commit): autofix

* refactor(shape_estimation): rework parameters

Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>

* refactor(shape_estimation): rework parameters

Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>

---------

Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants