-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(shape_estimation): rework parameters #5330
refactor(shape_estimation): rework parameters #5330
Conversation
Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR 👍
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry, I forgot to approve because I thought it's enough with Saito-san's approve.
Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please confirm if the node can be launched after the changes?
Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5330 +/- ##
==========================================
- Coverage 15.32% 0.00% -15.33%
==========================================
Files 1721 36 -1685
Lines 118559 689 -117870
Branches 37995 0 -37995
==========================================
- Hits 18169 0 -18169
+ Misses 79657 689 -78968
+ Partials 20733 0 -20733
☔ View full report in Codecov by Sentry. |
@miursh cc @PhoebeWu21 Could you review again...? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry for the late response.
* refactor(shape_estimation): rework parameters Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com> * style(pre-commit): autofix * refactor(shape_estimation): rework parameters Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com> * refactor(shape_estimation): rework parameters Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com> --------- Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* refactor(shape_estimation): rework parameters Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com> * style(pre-commit): autofix * refactor(shape_estimation): rework parameters Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com> * refactor(shape_estimation): rework parameters Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com> --------- Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* refactor(shape_estimation): rework parameters Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com> * style(pre-commit): autofix * refactor(shape_estimation): rework parameters Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com> * refactor(shape_estimation): rework parameters Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com> --------- Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* refactor(shape_estimation): rework parameters Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com> * style(pre-commit): autofix * refactor(shape_estimation): rework parameters Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com> * refactor(shape_estimation): rework parameters Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com> --------- Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* refactor(shape_estimation): rework parameters Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com> * style(pre-commit): autofix * refactor(shape_estimation): rework parameters Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com> * refactor(shape_estimation): rework parameters Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com> --------- Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the
shape_estimation
package.Tests performed
Package built and launch locally.
colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to shape_estimation
Effects on system behavior
More reliable and faster parameter configuration file creation.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.