Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lane_change): filter out objects out of lane to fix stopping margin chattering #5321

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Oct 16, 2023

Description

currently target_objects includes objects out of target lanes, this causes chattering of stopping margin, so filter them out

lc_filtering-2023-10-16_16.29.34.mp4
lc_filtering-2023-10-16_17.16.06.mp4

Related links

Tests performed

psim

evaluator_description: fix/lc_outof_lane_obj
2023/10/16 https://evaluation.tier4.jp/evaluation/reports/45177ccb-ee3a-50ae-b235-e0116a93b666/?project_id=prd_jt

Notes for reviewers

fails are not related to this PR and will be fixed in #5325

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 16, 2023
@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 16, 2023
…in chattering

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the fix/lc_outof_lane_obj branch from 9d731df to 1600733 Compare October 16, 2023 11:21
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (dad4722) 14.77% compared to head (1600733) 14.77%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5321      +/-   ##
==========================================
- Coverage   14.77%   14.77%   -0.01%     
==========================================
  Files        1664     1664              
  Lines      115081   115084       +3     
  Branches    35496    35498       +2     
==========================================
  Hits        17008    17008              
- Misses      78889    78892       +3     
  Partials    19184    19184              
Flag Coverage Δ *Carryforward flag
differential 12.26% <0.00%> (?)
total 14.77% <ø> (ø) Carriedforward from dad4722

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...th_planner/src/scene_module/lane_change/normal.cpp 3.90% <0.00%> (-0.02%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 merged commit 738c376 into main Oct 17, 2023
@kosuke55 kosuke55 deleted the fix/lc_outof_lane_obj branch October 17, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants