Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): curvature based drivable area expansion #5294

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Oct 12, 2023

Description

Replace the polygon-based dynamic drivable area expansion with a curvature-based algorithm.

Related links

Tests performed

Psim.
Evaluation platform (TIER IV INTERNAL LINK).

Notes for reviewers

Launch PR: autowarefoundation/autoware_launch#632

Interface changes

Parameters for this feature were changed.
See the documentation for the details.

Effects on system behavior

Drivable area expansion should be more stable, less computationally expensive, and less prone to bugs.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 12, 2023
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
This reverts commit e8f04de.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem force-pushed the feat/new_dynamic_drivablea_area_expansion branch from 176b431 to c8a86c0 Compare October 16, 2023 04:41
@maxime-clem maxime-clem added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 16, 2023
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well with a bus. LGTM.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 139 lines in your changes are missing coverage. Please review.

Comparison is base (5725c2d) 14.80% compared to head (aec72f9) 14.81%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5294   +/-   ##
=======================================
  Coverage   14.80%   14.81%           
=======================================
  Files        1665     1665           
  Lines      115286   115242   -44     
  Branches    35600    35580   -20     
=======================================
+ Hits        17068    17071    +3     
+ Misses      78958    78948   -10     
+ Partials    19260    19223   -37     
Flag Coverage Δ *Carryforward flag
differential 12.27% <39.30%> (?)
total 14.76% <ø> (-0.04%) ⬇️ Carriedforward from 5d6449d

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...ner/include/behavior_path_planner/data_manager.hpp 50.00% <ø> (ø)
planning/behavior_path_planner/src/utils/utils.cpp 13.63% <0.00%> (+0.06%) ⬆️
.../utils/drivable_area_expansion/path_projection.hpp 69.23% <75.00%> (+0.13%) ⬆️
...r/src/utils/drivable_area_expansion/footprints.cpp 26.31% <16.66%> (-11.19%) ⬇️
...er/src/utils/drivable_area_expansion/map_utils.cpp 36.36% <37.50%> (+14.14%) ⬆️
...anner/utils/drivable_area_expansion/parameters.hpp 12.12% <11.11%> (-7.33%) ⬇️
...or_path_planner/src/behavior_path_planner_node.cpp 27.45% <0.00%> (ø)
...path_planner/test/test_drivable_area_expansion.cpp 34.01% <32.14%> (+3.24%) ⬆️
...rivable_area_expansion/drivable_area_expansion.cpp 45.39% <44.02%> (+9.39%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 merged commit dbc6de6 into autowarefoundation:main Oct 16, 2023
@maxime-clem maxime-clem deleted the feat/new_dynamic_drivablea_area_expansion branch June 28, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants