Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lane_change): separate execution and cancel safety check param #5246

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 commented Oct 6, 2023

Description

Separating the parameters for safety check during lane change execution and lane change cancel.

THE FOLLOWING NEEDS TO BE MERGE FIRST: autowarefoundation/autoware_launch#626

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 6, 2023
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zulfaqar-azmi-t4
Copy link
Contributor Author

No degradation occured: 1689/1691 failed scenarios are not lane change.

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Attention: 41 lines in your changes are missing coverage. Please review.

Comparison is base (950805f) 14.78% compared to head (adb852b) 14.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5246      +/-   ##
==========================================
- Coverage   14.78%   14.78%   -0.01%     
==========================================
  Files        1648     1648              
  Lines      113977   113996      +19     
  Branches    35122    35135      +13     
==========================================
  Hits        16850    16850              
- Misses      78184    78198      +14     
- Partials    18943    18948       +5     
Flag Coverage Δ *Carryforward flag
differential 12.42% <0.00%> (?)
total 14.78% <ø> (+<0.01%) ⬆️ Carriedforward from 950805f

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...nner/utils/lane_change/lane_change_module_data.hpp 0.00% <ø> (ø)
...h_planner/src/scene_module/lane_change/manager.cpp 4.56% <0.00%> (-0.44%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit 057d3d4 into autowarefoundation:main Oct 6, 2023
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the feat-lc-separate-cancel-parameter branch October 6, 2023 11:17
zulfaqar-azmi-t4 added a commit to tier4/autoware.universe that referenced this pull request Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants