-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lane_change): separate execution and cancel safety check param #5246
feat(lane_change): separate execution and cancel safety check param #5246
Conversation
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
514f058
to
adb852b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No degradation occured: 1689/1691 failed scenarios are not lane change. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5246 +/- ##
==========================================
- Coverage 14.78% 14.78% -0.01%
==========================================
Files 1648 1648
Lines 113977 113996 +19
Branches 35122 35135 +13
==========================================
Hits 16850 16850
- Misses 78184 78198 +14
- Partials 18943 18948 +5
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
…utowarefoundation#5246) Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Description
Separating the parameters for safety check during lane change execution and lane change cancel.
THE FOLLOWING NEEDS TO BE MERGE FIRST: autowarefoundation/autoware_launch#626
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.