-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(intersection)!: disable the exception behavior in the private areas #5229
feat(intersection)!: disable the exception behavior in the private areas #5229
Conversation
…cle in the private areas feat: change behavior in the private areas Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5229 +/- ##
==========================================
- Coverage 14.79% 14.75% -0.05%
==========================================
Files 1648 1648
Lines 113928 114521 +593
Branches 35072 35557 +485
==========================================
+ Hits 16860 16897 +37
- Misses 78145 78664 +519
- Partials 18923 18960 +37
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Can you also remove the stuck_private_timeout_ variable because it is not used anymore? |
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
@soblin Thank you for the comments. |
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
…eas (autowarefoundation#5229) * feat: make configurable to disable the exception treat of stuck obstacle in the private areas feat: change behavior in the private areas Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> * delete the coment outed lines Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> * change "enabled" to "enable" Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> * fix setting Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> * delete unused variables Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> --------- Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
…eas (autowarefoundation#5229) * feat: make configurable to disable the exception treat of stuck obstacle in the private areas feat: change behavior in the private areas Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> * delete the coment outed lines Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> * change "enabled" to "enable" Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> * fix setting Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> * delete unused variables Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> --------- Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Description
This PR contains two objectives
Related links
Related PR for launch setting
autowarefoundation/autoware_launch#622
Tests performed
psim test was performed.
![image](https://private-user-images.githubusercontent.com/141538661/272817828-b7078784-efd9-40b8-a1a9-3855f5f85fcb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2ODc1OTcsIm5iZiI6MTczOTY4NzI5NywicGF0aCI6Ii8xNDE1Mzg2NjEvMjcyODE3ODI4LWI3MDc4Nzg0LWVmZDktNDBiOC1hMWE5LTM4NTVmNWY4NWZjYi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNlQwNjI4MTdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lOGFjNjA5ODA4OWM4NmYzMzQyMzM3MDkxMjA5ZjZhOWU2N2UyNTJlOTNlNDAxOWI4YjVlMDgwNjAwNjc0ZDBmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.9tbJP-_zTI4IQ1vCshZsnHLQHiVA9fBh5-t46wMGGn0)
disabled
enabled
![image](https://private-user-images.githubusercontent.com/141538661/272817675-44dc75ec-66f0-4ef6-a5ea-24977f3be606.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2ODc1OTcsIm5iZiI6MTczOTY4NzI5NywicGF0aCI6Ii8xNDE1Mzg2NjEvMjcyODE3Njc1LTQ0ZGM3NWVjLTY2ZjAtNGVmNi1hNWVhLTI0OTc3ZjNiZTYwNi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNlQwNjI4MTdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0zYzQwZWU3OTEyMDllNDFkNjdlODE4ZDhlZDc5OTQ1YTExNGI0Yzk4M2Q3ZjMzNDViMTQwM2RkY2VhMWMwMDQzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.Q3QXY5vzlCNXFem4QNplJYH3r8bgGzkIlCaNTGl9x8w)
https://evaluation.tier4.jp/evaluation/reports/fd946252-3247-50f5-9a70-128092c8a5c6?project_id=prd_jt
https://star4.slack.com/archives/C03QW0GU6P7/p1696496558303159
Notes for reviewers
Nothing
Interface changes
New enable/disable parameter is added
Effects on system behavior
No longer behave exceptionally on private area.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.