Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(out_of_lane): improve stop decision #5207

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Oct 2, 2023

Description

This PR improves the creation of the stop point decided by the out_of_lane module.

Related links

Launch PR: autowarefoundation/autoware_launch#615

Tests performed

Psim.

Notes for reviewers

Interface changes

Effects on system behavior

The out_of_lane module stop point is better calculated but it is still too unstable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@maxime-clem maxime-clem added component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Oct 2, 2023
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Oct 2, 2023
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@maxime-clem maxime-clem force-pushed the fix/out_of_lane-improve_stop_decision branch from c51223d to 4f4b4f7 Compare October 3, 2023 01:58
@maxime-clem maxime-clem enabled auto-merge (squash) October 3, 2023 01:59
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 49 lines in your changes are missing coverage. Please review.

Comparison is base (bab1453) 14.77% compared to head (4f4b4f7) 14.77%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5207      +/-   ##
==========================================
- Coverage   14.77%   14.77%   -0.01%     
==========================================
  Files        1636     1637       +1     
  Lines      113647   113642       -5     
  Branches    34941    34937       -4     
==========================================
- Hits        16793    16790       -3     
+ Misses      78014    78010       -4     
- Partials    18840    18842       +2     
Flag Coverage Δ *Carryforward flag
differential 22.74% <10.90%> (?)
total 14.77% <ø> (+<0.01%) ⬆️ Carriedforward from bab1453

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...behavior_velocity_out_of_lane_module/src/types.hpp 22.72% <ø> (ø)
...ut_of_lane_module/src/filter_predicted_objects.hpp 9.52% <0.00%> (+0.43%) ⬆️
...vior_velocity_out_of_lane_module/src/footprint.cpp 57.14% <50.00%> (ø)
...havior_velocity_out_of_lane_module/src/manager.cpp 19.14% <0.00%> (ø)
...city_out_of_lane_module/src/lanelets_selection.cpp 29.03% <0.00%> (-2.01%) ⬇️
...vior_velocity_out_of_lane_module/src/decisions.cpp 1.11% <0.00%> (+0.01%) ⬆️
...ocity_out_of_lane_module/src/scene_out_of_lane.cpp 25.84% <0.00%> (+<0.01%) ⬆️
...t_of_lane_module/src/calculate_slowdown_points.hpp 18.51% <18.51%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxime-clem maxime-clem merged commit 8c38126 into autowarefoundation:main Oct 3, 2023
@maxime-clem maxime-clem deleted the fix/out_of_lane-improve_stop_decision branch October 3, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants