Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_velocity_planner): intersection module considers merge_from_private module's output #5187

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Oct 1, 2023

Description

By the following PR, the intersection module considers the stop point in the input path for collision checking.
#5156

By moving the merge_from_private before the intersection, the intersection module can consider the merge_from_private's output as well.

Tests performed

psim

Effects on system behavior

Intersection module's collision checking with the result of merge_from_private module.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 1, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review October 1, 2023 13:24
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 1, 2023
@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6155f1f) 14.79% compared to head (c32727f) 14.80%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5187   +/-   ##
=======================================
  Coverage   14.79%   14.80%           
=======================================
  Files        1648     1648           
  Lines      113918   113906   -12     
  Branches    35074    35075    +1     
=======================================
  Hits        16859    16859           
+ Misses      78135    78123   -12     
  Partials    18924    18924           
Flag Coverage Δ *Carryforward flag
differential 6.37% <0.00%> (?)
total 14.80% <ø> (+<0.01%) ⬆️ Carriedforward from f728585

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
..._image_processing/src/undistort/undistort_node.cpp 0.00% <ø> (ø)
planning/obstacle_cruise_planner/src/node.cpp 12.42% <ø> (+0.07%) ⬆️
...avior_velocity_intersection_module/src/manager.cpp 16.59% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 force-pushed the feat/intersection-consider-merge-from-private branch from d98dbd2 to 01d9b73 Compare October 2, 2023 00:17
…from_private module's output

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the feat/intersection-consider-merge-from-private branch from 01d9b73 to f728585 Compare October 4, 2023 07:50
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Copy link

stale bot commented Dec 3, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Dec 3, 2023
@takayuki5168 takayuki5168 deleted the feat/intersection-consider-merge-from-private branch June 8, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) status:stale Inactive or outdated issues. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants