Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crosswalk): fix module launch condition #5129

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Sep 26, 2023

Description

Applied the following fix to the crosswalk.
#4823


Fix module launch condition so that it can activate crosswalk module in the map which has both regulatory element crosswalk and non regulatory element crosswalk.

Tests performed

psim
scenario test: https://evaluation.tier4.jp/evaluation/reports/4e7da0bf-e29b-5060-8c29-562bbbb7827a?project_id=prd_jt

Effects on system behavior

Make it possible to use crosswalk module in specific map.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 26, 2023
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the fix/crosswalk-launch-condition-main branch from 3448ab6 to 9bec5e0 Compare September 26, 2023 02:16
@takayuki5168 takayuki5168 marked this pull request as ready for review September 26, 2023 02:16
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 26, 2023
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (46f871f) 14.97% compared to head (9bec5e0) 14.97%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5129   +/-   ##
=======================================
  Coverage   14.97%   14.97%           
=======================================
  Files        1613     1613           
  Lines      111984   111973   -11     
  Branches    34692    34683    -9     
=======================================
- Hits        16764    16763    -1     
+ Misses      76485    76481    -4     
+ Partials    18735    18729    -6     
Flag Coverage Δ *Carryforward flag
differential 9.57% <0.00%> (?)
total 14.97% <ø> (+<0.01%) ⬆️ Carriedforward from 46f871f

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...behavior_velocity_crosswalk_module/src/manager.hpp 100.00% <ø> (ø)
...g/behavior_velocity_walkway_module/src/manager.hpp 100.00% <ø> (ø)
...g/behavior_velocity_walkway_module/src/manager.cpp 22.22% <0.00%> (+2.77%) ⬆️
...behavior_velocity_crosswalk_module/src/manager.cpp 10.00% <0.00%> (-0.82%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 merged commit 0153e54 into autowarefoundation:main Sep 26, 2023
@takayuki5168 takayuki5168 deleted the fix/crosswalk-launch-condition-main branch September 26, 2023 09:31
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Sep 26, 2023
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants