Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior path planner): simplify code by using lambda #5124

Conversation

danielsanchezaran
Copy link
Contributor

@danielsanchezaran danielsanchezaran commented Sep 25, 2023

Description

🤖 Generated by Copilot at 66ccb58

Refactor behavior_path_planner_node.cpp to use lambda function for scene module registration and publisher creation. This simplifies the code and avoids repetition.

Tests performed

Ran PSim and checked that the behavior path planning modules are launched/used normally.

Effects on system behavior

N/A

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 25, 2023
@danielsanchezaran danielsanchezaran changed the title reaftor(behavior path planner): simplify code by using lambda refactor(behavior path planner): simplify code by using lambda Sep 26, 2023
@danielsanchezaran danielsanchezaran marked this pull request as ready for review September 29, 2023 04:56
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!
Thank you so much for your work 😍

@danielsanchezaran danielsanchezaran enabled auto-merge (squash) September 29, 2023 06:20
@rej55 rej55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 29, 2023
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (1caa1b3) 14.86% compared to head (5faa5e8) 14.85%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5124      +/-   ##
==========================================
- Coverage   14.86%   14.85%   -0.02%     
==========================================
  Files        1629     1629              
  Lines      112863   113162     +299     
  Branches    34900    35110     +210     
==========================================
+ Hits        16782    16814      +32     
- Misses      77241    77501     +260     
- Partials    18840    18847       +7     
Flag Coverage Δ *Carryforward flag
differential 12.56% <11.11%> (?)
total 14.87% <ø> (+<0.01%) ⬆️ Carriedforward from 1caa1b3

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...or_path_planner/src/behavior_path_planner_node.cpp 27.50% <11.11%> (+0.45%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielsanchezaran danielsanchezaran merged commit ad69c28 into autowarefoundation:main Sep 29, 2023
@danielsanchezaran danielsanchezaran deleted the refactor/register-and-create-publisher branch September 29, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants