fix(pid_longitudinal_controller): use is_autoware_control_enabled for manual driving #5092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… manual driving Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
|
@TakaHoribe Could you check if my understanding is correct. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #5092 +/- ##
==========================================
- Coverage 15.77% 15.77% -0.01%
==========================================
Files 1584 1584
Lines 109568 109569 +1
Branches 33728 33730 +2
==========================================
Hits 17286 17286
- Misses 73656 73657 +1
Partials 18626 18626
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
TakaHoribe
approved these changes
Sep 25, 2023
takayuki5168
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 25, 2023
… manual driving (autowarefoundation#5092) * fix(pid_longitudinal_controller): use is_autoware_control_enabled for manual driving Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
4 tasks
maxime-clem
pushed a commit
to maxime-clem/autoware.universe
that referenced
this pull request
Oct 2, 2023
… manual driving (autowarefoundation#5092) * fix(pid_longitudinal_controller): use is_autoware_control_enabled for manual driving Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following PR uses
m_current_operation_mode.modeto know if the current driving is autonomous or manual.However, in my understanding, this value can be
AUTONOMOUSeven when the driving is manual.#2619
Actually, I think
m_current_operation_mode.is_autoware_control_enabled && m_current_operation_mode.mode == OperationModeState::AUTONOMOUSis the correct one.Tests performed
nothing
Effects on system behavior
nothing
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.