Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(motion_velocity_smoother): add enable curve filtering param #5064

Merged

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Sep 21, 2023

Description

Add a parameter to control "lateral acceleration filter" and "steering rate filter" in the motion_velocity_smoother.

smother-param-2023-09-21_14.24.40.mp4

Tests performed

Run psim

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Sep 21, 2023
@TakaHoribe TakaHoribe added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 22, 2023
Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage: 32.48% and project coverage change: +0.01% 🎉

Comparison is base (aae343b) 15.71% compared to head (15a4ec1) 15.73%.
Report is 49 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5064      +/-   ##
==========================================
+ Coverage   15.71%   15.73%   +0.01%     
==========================================
  Files        1579     1589      +10     
  Lines      109343   113010    +3667     
  Branches    34110    36147    +2037     
==========================================
+ Hits        17185    17779     +594     
- Misses      73247    75755    +2508     
- Partials    18911    19476     +565     
Flag Coverage Δ *Carryforward flag
differential 11.62% <33.33%> (?)
total 15.80% <32.47%> (+0.09%) ⬆️ Carriedforward from 27220a8

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...otion_utils/marker/virtual_wall_marker_creator.hpp 50.00% <ø> (ø)
...s/include/motion_utils/resample/resample_utils.hpp 84.21% <ø> (ø)
common/motion_utils/src/marker/marker_helper.cpp 51.16% <ø> (ø)
...n_utils/src/marker/virtual_wall_marker_creator.cpp 81.08% <ø> (ø)
common/motion_utils/src/resample/resample.cpp 33.75% <ø> (ø)
...n/motion_utils/test/src/resample/test_resample.cpp 21.82% <ø> (ø)
common/motion_utils/test/src/test_motion_utils.cpp 66.66% <ø> (ø)
...ils/test/src/trajectory/test_path_with_lane_id.cpp 32.50% <ø> (-6.25%) ⬇️
...include/tier4_autoware_utils/geometry/geometry.hpp 86.66% <0.00%> (-4.04%) ⬇️
...t/src/geometry/test_path_with_lane_id_geometry.cpp 52.50% <ø> (ø)
... and 60 more

... and 57 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TakaHoribe TakaHoribe merged commit 7af40fc into autowarefoundation:main Sep 25, 2023
@TakaHoribe TakaHoribe deleted the smoother-latearal-acc-velocity branch September 25, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants