Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(planning_validator): improve curvature calculation for less noise #5049

Merged

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Sep 20, 2023

Description

When driving autonomously, occasionally an error message stating "Lateral acceleration is too high" appears on the terminal.

image

This issue arises because the planning_validator calculates curvature based on three consecutive points. These closely spaced points can produce extremely high curvature results due to noise. We are not interested in the curvature of a path separated by only 1mm; what we really want to know is the curvature over a few meters. I've now modified it to compute the curvature based on three points that are 1m apart.

Note: Parameterizing this distance is on our to-do list for future updates.

Related links

TIERIV Internal ticket

Tests performed

run psim

Notes for reviewers

None

Interface changes

None

Effects on system behavior

planning validation for the lateral acceleration will get less sensitive to noises.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Sorry, something went wrong.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 20, 2023
@TakaHoribe TakaHoribe added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 54.54% and project coverage change: -0.10% ⚠️

Comparison is base (27220a8) 15.81% compared to head (9589069) 15.71%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5049      +/-   ##
==========================================
- Coverage   15.81%   15.71%   -0.10%     
==========================================
  Files        1581     1577       -4     
  Lines      109896   109160     -736     
  Branches    34411    34022     -389     
==========================================
- Hits        17375    17150     -225     
+ Misses      73394    73123     -271     
+ Partials    19127    18887     -240     
Flag Coverage Δ *Carryforward flag
differential 48.24% <57.14%> (?)
total 15.70% <0.00%> (-0.11%) ⬇️ Carriedforward from f9b1c70

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...analysis/src/control_performance_analysis_node.cpp 0.00% <ø> (ø)
...ol/operation_mode_transition_manager/src/state.cpp 0.00% <ø> (ø)
...ol/operation_mode_transition_manager/src/state.hpp 0.00% <ø> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 13.09% <0.00%> (+0.65%) ⬆️
planning/planning_validator/src/utils.cpp 60.71% <57.14%> (+2.61%) ⬆️

... and 35 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@TakaHoribe TakaHoribe enabled auto-merge (squash) September 21, 2023 02:44
@TakaHoribe TakaHoribe merged commit c4a7e54 into autowarefoundation:main Sep 21, 2023
@TakaHoribe TakaHoribe deleted the planning-validator-fix-curvature-calc branch September 21, 2023 02:44
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 27, 2024
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants