-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ekf_localizer): ignore dead band of velocity sensor #5042
Merged
kminoda
merged 9 commits into
autowarefoundation:main
from
kminoda:feat/ekf_localizer/ignore_dead_band_of_velocity_sensor
Sep 20, 2023
Merged
feat(ekf_localizer): ignore dead band of velocity sensor #5042
kminoda
merged 9 commits into
autowarefoundation:main
from
kminoda:feat/ekf_localizer/ignore_dead_band_of_velocity_sensor
Sep 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
…dead_band_of_velocity_sensor
Merged
4 tasks
Signed-off-by: kminoda <koji.minoda@tier4.jp>
YamatoAndo
approved these changes
Sep 20, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #5042 +/- ##
==========================================
+ Coverage 15.71% 15.76% +0.04%
==========================================
Files 1579 1581 +2
Lines 109343 109508 +165
Branches 34110 34216 +106
==========================================
+ Hits 17183 17263 +80
+ Misses 73247 73228 -19
- Partials 18913 19017 +104
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
kminoda
added a commit
to kminoda/autoware.universe
that referenced
this pull request
Sep 21, 2023
…ndation#5042) * feat(ekf_localizer): ignore dead band of velocity sensor Signed-off-by: kminoda <koji.minoda@tier4.jp> * update Signed-off-by: kminoda <koji.minoda@tier4.jp> * update readme Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * update stop_filter as well Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:localization
Vehicle's position determination in its environment. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current Autoware is not capable of dealing the dead zone in velocity sensors, which is a common phenomena we may encounter with some HW. This potentially could cause several issues especially around planning & control modules.
As the most simple solution, I would like to modify EKF so that it will ignore velocity when the observed velocity is below a certain threshold. It is set
0.0
by default, in which case it will not affect the system at all.Let's say we have a velocity sensor which will be 0.0 [m/s] when the velocity is below 0.5 [m/s]. In such case, I recommend to set the
threshold_observable_velocity_mps
to0.5
.Related links
Must be merged after autowarefoundation/autoware_launch#574
Tests performed
Feed Autoware a velocity sensor with the value less that 0.5[m/s] rounded into 0.0[m/s]. (Note that the caption is wrong for the following figures)
With the default value (the same performance as the original EKF), we can see that the estimated velocity shows very similar behavior as the input sensor data.
![image](https://private-user-images.githubusercontent.com/44218668/269138673-7b50e450-503d-4dce-b0dc-e6fa8c2a44c3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNjY1MTgsIm5iZiI6MTczOTM2NjIxOCwicGF0aCI6Ii80NDIxODY2OC8yNjkxMzg2NzMtN2I1MGU0NTAtNTAzZC00ZGNlLWIwZGMtZTZmYThjMmE0NGMzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDEzMTY1OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWEwNTVhNjBjN2U5YjI3MzQzM2Y4N2I4ZDAyODQ3ZDgxYzAwNTIzNjA0YWQyYmYyNTQxMjdkYjU5ZWQ5YzI2ZWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.jqt7z-yCdTPMf_pcKJLIQVfmvrxoobz0M_V73zP0HnY)
By setting the appropriate value as
threshold_observable_velocity_mps: 0.5
, we observe that the performance improves, albeit not perfectly.Notes for reviewers
None
Interface changes
None
Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.