Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_perception_launch): add object_merger of far_objects to fusion for Camera-LiDAR-Radar fusion #5026

Merged

Conversation

scepter914
Copy link
Contributor

Description

Remake PR from #4995.

This PR add object_merger of far_objects to fusion for Camera-LiDAR-Radar fusion and refactor according to it.

  • Add object_merger of far_objects in launch/object_recognition/detection/camera_lidar_radar_fusion_based_detection.launch.xml

Until the tracking merger can operate stably, this PR temporarily added near_object and far_object mergers to the detection side and connected the far detection pipeline to tracking.
near_object come from existing Camera-LiDAR-Radar fusion and far_object come from radar detection.

  • Add radar lanelets filter parameter to detection launch

I added radar lanelets filter parameter to detection launch to use config parameter from autoware.launch

  • Refactor parameter name and comment

To make it easier to understand parameters, I renamed parameter names and comment.

Related links

Tests performed

Tests by rosbag.

Screenshot from 2023-09-14 17-20-34

Red objects are detection/radar/far_object.
Other objects are tracking/objects.
Grid size is 10m.
I could confirm that the long-distance detection was working properly with tracking.

Notes for reviewers

Interface changes

None

Effects on system behavior

As adding faraway detection, dynamic objects at a distance become visible, so it effects to planning behavior.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…ion for Camera-LiDAR-Radar fusion

Signed-off-by: scepter914 <scepter914@gmail.com>
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Sep 19, 2023
@scepter914 scepter914 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 19, 2023
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: scepter914 <scepter914@gmail.com>
…toware.universe into feat/merge_far_detection_2
@scepter914 scepter914 merged commit cca5fee into autowarefoundation:main Sep 19, 2023
@scepter914 scepter914 deleted the feat/merge_far_detection_2 branch September 19, 2023 05:17
YoshiRi pushed a commit to YoshiRi/autoware.universe that referenced this pull request Oct 16, 2023
…ion for Camera-LiDAR-Radar fusion (autowarefoundation#5026)

* fix(tier4_perception_launch): add object_merger of far_objects to fusion for Camera-LiDAR-Radar fusion

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix conflict

Signed-off-by: scepter914 <scepter914@gmail.com>

---------

Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants