Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lanelet2_projector): fix werror return-type #5019

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Sep 18, 2023

Description

fix

/home/kosuke55/pilot-auto/src/autoware/universe/common/geography_utils/src/lanelet2_projector.cpp:53:1: error: control reaches end of non-void function [-Werror=return-type]
   53 | }

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 requested a review from kminoda as a code owner September 18, 2023 06:19
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Sep 18, 2023
@kosuke55
Copy link
Contributor Author

related :#4883

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (ea9d4b0) 15.74% compared to head (823f4b8) 15.74%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5019      +/-   ##
==========================================
- Coverage   15.74%   15.74%   -0.01%     
==========================================
  Files        1587     1587              
  Lines      109831   109793      -38     
  Branches    33719    33691      -28     
==========================================
- Hits        17292    17284       -8     
+ Misses      73908    73897      -11     
+ Partials    18631    18612      -19     
Flag Coverage Δ *Carryforward flag
differential 23.89% <0.00%> (?)
total 15.74% <ø> (-0.01%) ⬇️ Carriedforward from d7422ea

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
common/geography_utils/src/lanelet2_projector.cpp 41.17% <0.00%> (ø)
..._safety_checker/path_safety_checker_parameters.hpp 33.33% <ø> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 11.63% <ø> (-0.06%) ⬇️
.../scene_module/goal_planner/goal_planner_module.cpp 8.52% <ø> (+0.03%) ⬆️
..._planner/src/scene_module/goal_planner/manager.cpp 5.69% <ø> (+0.13%) ⬆️
...th_planner/src/scene_module/lane_change/normal.cpp 4.05% <ø> (+<0.01%) ⬆️
...planner/src/scene_module/start_planner/manager.cpp 5.00% <ø> (+0.13%) ⬆️
...cene_module/start_planner/start_planner_module.cpp 29.91% <ø> (+0.05%) ⬆️
...ehavior_path_planner/src/utils/avoidance/utils.cpp 9.54% <ø> (-0.46%) ⬇️
...avior_path_planner/src/utils/lane_change/utils.cpp 0.43% <ø> (+<0.01%) ⬆️
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@kosuke55 kosuke55 enabled auto-merge (squash) September 19, 2023 00:54
@kosuke55 kosuke55 merged commit 7eabe35 into main Sep 19, 2023
@kosuke55 kosuke55 deleted the fix/lanelet2_projector_werror branch September 19, 2023 01:19
scepter914 pushed a commit to scepter914/autoware.universe that referenced this pull request Sep 19, 2023
)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants