Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): use common function of createPredictedPath from avoidance module #5015

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Sep 17, 2023

Description

🤖 Generated by Copilot at c116f1a

Refactored convertToPredictedPath function to use a common utility and added a new parameter to handle different velocity scenarios. Updated the function call in avoidance_module.cpp to pass the new parameter.

This PR shuold be merged first.

Tests performed

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 17, 2023
@kyoichi-sugahara kyoichi-sugahara marked this pull request as ready for review September 18, 2023 00:43
@kyoichi-sugahara kyoichi-sugahara added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage: 44.44% and no project coverage change.

Comparison is base (ea9d4b0) 15.74% compared to head (c116f1a) 15.75%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5015   +/-   ##
=======================================
  Coverage   15.74%   15.75%           
=======================================
  Files        1587     1587           
  Lines      109831   109843   +12     
  Branches    33719    33722    +3     
=======================================
+ Hits        17292    17303   +11     
+ Misses      73908    73907    -1     
- Partials    18631    18633    +2     
Flag Coverage Δ *Carryforward flag
differential 17.85% <44.44%> (?)
total 15.73% <ø> (-0.01%) ⬇️ Carriedforward from 67eae01

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
..._safety_checker/path_safety_checker_parameters.hpp 50.00% <ø> (+16.66%) ⬆️
.../scene_module/goal_planner/goal_planner_module.cpp 8.49% <0.00%> (ø)
..._planner/src/scene_module/goal_planner/manager.cpp 5.51% <0.00%> (-0.05%) ⬇️
...planner/src/scene_module/start_planner/manager.cpp 4.82% <0.00%> (-0.05%) ⬇️
...cene_module/start_planner/start_planner_module.cpp 29.86% <0.00%> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 11.69% <50.00%> (ø)
...ehavior_path_planner/src/utils/avoidance/utils.cpp 10.83% <90.00%> (+0.83%) ⬆️
...rc/utils/path_safety_checker/objects_filtering.cpp 25.33% <100.00%> (+1.68%) ⬆️
...nner/src/utils/start_goal_planner_common/utils.cpp 53.03% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kyoichi-sugahara kyoichi-sugahara merged commit 498dbef into autowarefoundation:main Sep 18, 2023
@kyoichi-sugahara kyoichi-sugahara deleted the feature/use_common_function_of_createPredictedPath branch September 18, 2023 23:18
scepter914 pushed a commit to scepter914/autoware.universe that referenced this pull request Sep 19, 2023
…th from avoidance module (autowarefoundation#5015)

* update function of create predicted path

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* util common function of create predicted path from avoidance module

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants