-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(build): only include forward declaration of lanelet stuff in route_handler header files #4996
chore(build): only include forward declaration of lanelet stuff in route_handler header files #4996
Conversation
…andler, planning/behavior_path_planner, planning/behavior_velocity_planners(fix these later) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
2889f75
to
513619d
Compare
...ng/behavior_path_planner/src/utils/geometric_parallel_parking/geometric_parallel_parking.cpp
Show resolved
Hide resolved
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4996 +/- ##
=======================================
Coverage 15.74% 15.74%
=======================================
Files 1587 1587
Lines 109797 109797
Branches 33707 33707
=======================================
+ Hits 17287 17288 +1
Misses 73882 73882
+ Partials 18628 18627 -1
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem regarding speed_bump
module.
@kosuke55 Can you approve this PR ? |
Description
I minimized the route_handler/behavior_path_planner/behavior_velocity_planner_common header files to include forward declaration of lanelet packages as much as possible.
#4821
Tests performed
Psim works
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.