Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): only include forward declaration of lanelet stuff in route_handler header files #4996

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Sep 14, 2023

Description

I minimized the route_handler/behavior_path_planner/behavior_velocity_planner_common header files to include forward declaration of lanelet packages as much as possible.

#4821

Tests performed

Psim works

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 14, 2023
@soblin soblin changed the title chore(build): only include forward declaration of lanelet stuff in planning/ header files chore(build): only include forward declaration of lanelet stuff in route_handler header files Sep 14, 2023
…andler, planning/behavior_path_planner, planning/behavior_velocity_planners(fix these later)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the build-fast3/component/planning/fwd-decl-lanelet branch from 2889f75 to 513619d Compare September 14, 2023 08:43
@soblin soblin marked this pull request as ready for review September 14, 2023 11:40
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 42.85% and no project coverage change.

Comparison is base (b2e9ee3) 15.74% compared to head (513619d) 15.74%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4996   +/-   ##
=======================================
  Coverage   15.74%   15.74%           
=======================================
  Files        1587     1587           
  Lines      109797   109797           
  Branches    33707    33707           
=======================================
+ Hits        17287    17288    +1     
  Misses      73882    73882           
+ Partials    18628    18627    -1     
Flag Coverage Δ *Carryforward flag
differential 17.55% <42.85%> (?)
total 15.74% <ø> (-0.01%) ⬇️ Carriedforward from b2e9ee3

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ner/include/behavior_path_planner/data_manager.hpp 50.00% <ø> (ø)
...clude/behavior_path_planner/marker_utils/utils.hpp 0.00% <ø> (ø)
.../include/behavior_path_planner/planner_manager.hpp 51.16% <ø> (+1.16%) ⬆️
...cene_module/start_planner/start_planner_module.hpp 18.18% <ø> (ø)
...lude/behavior_path_planner/turn_signal_decider.hpp 87.50% <ø> (ø)
..._planner/utils/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...ic_parallel_parking/geometric_parallel_parking.hpp 16.66% <ø> (ø)
...nner/utils/lane_change/lane_change_module_data.hpp 0.00% <ø> (ø)
...nner/include/behavior_path_planner/utils/utils.hpp 45.45% <ø> (ø)
..._path_planner/src/marker_utils/avoidance/debug.cpp 5.16% <ø> (ø)
... and 36 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mehmetdogru mehmetdogru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem regarding speed_bump module.

@soblin
Copy link
Contributor Author

soblin commented Sep 15, 2023

@kosuke55 Can you approve this PR ?

@soblin soblin merged commit fd7db70 into autowarefoundation:main Sep 15, 2023
@soblin soblin deleted the build-fast3/component/planning/fwd-decl-lanelet branch September 15, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants