-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(object_merger): add queue size parameter #4994
feat(object_merger): add queue size parameter #4994
Conversation
Signed-off-by: scepter914 <scepter914@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4994 +/- ##
========================================
Coverage 15.74% 15.74%
========================================
Files 1587 1587
Lines 109802 109694 -108
Branches 33730 33642 -88
========================================
- Hits 17286 17275 -11
+ Misses 73890 73800 -90
+ Partials 18626 18619 -7
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Description
To merger between object with large time difference, this PR add queue size parameter for message filter.
As the perception process becomes longer, there are more opportunities to merge objects with header time differences.
So this PR add add queue size parameter for message filter in
object_merger
, and make it easier to debug for the message filter.Tests performed
Test by rosbag
Effects on system behavior
Default parameter is same as until now, so behavior doesn't change by this PR.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.