Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): only include forward declaration of lanelet stuff in control/ header files #4973

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Sep 12, 2023

Description

#4821

Tests performed

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Sep 12, 2023
@soblin soblin changed the title chore(build): only include forward declaration of lanelet stuff in control/ chore(build): only include forward declaration of lanelet stuff in control/ header files Sep 12, 2023
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9402bb5) 15.77% compared to head (683a457) 15.77%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4973   +/-   ##
=======================================
  Coverage   15.77%   15.77%           
=======================================
  Files        1584     1584           
  Lines      109568   109568           
  Branches    33728    33728           
=======================================
  Hits        17286    17286           
  Misses      73656    73656           
  Partials    18626    18626           
Flag Coverage Δ *Carryforward flag
differential 17.22% <ø> (?)
total 15.77% <ø> (ø) Carriedforward from 9402bb5

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
..._departure_checker/lane_departure_checker_node.hpp 0.00% <ø> (ø)
...rture_checker_node/lane_departure_checker_node.cpp 0.28% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit a959ae7 into autowarefoundation:main Sep 13, 2023
@soblin soblin deleted the build-fast3/component/control/fwd-decl-lanelet branch September 14, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants