-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(traffic_light_classifier): update training docs #4917
refactor(traffic_light_classifier): update training docs #4917
Conversation
Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>
@yukke42 @miursh @yukkysaito Could you look into this PR? |
Thank you for your PR 👍 |
@yukkysaito Saito-san thanks for your feedback. Mitsudome-san also agrees with you, I will refactor PR after it is done. |
@mitsudome-r How about you? |
@yukkysaito Saito-san, he also has the same idea as you. I updated the PR. After @xmfcx upload traffic_light_sample_dataset to AWS, I will open PR to review. |
Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>
Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>
Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>
@yukkysaito @miursh @yukke42 Could you review this PR or assign an appropriate reviewer? FYI: @mitsudome-r |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4917 +/- ##
==========================================
+ Coverage 15.14% 15.65% +0.51%
==========================================
Files 1581 1584 +3
Lines 110014 108904 -1110
Branches 34487 33280 -1207
==========================================
+ Hits 16660 17054 +394
+ Misses 74710 73353 -1357
+ Partials 18644 18497 -147
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Description
Training of the traffic light classifier model isn't up-to-date. Model training and ONNX conversion scripts changed up-to-date repos of mmlab.
I have updated the custom training and detailed more.
autowarefoundation/autoware-documentation#447
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.