Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(traffic_light_classifier): update training docs #4917

Conversation

kaancolak
Copy link
Contributor

@kaancolak kaancolak commented Sep 7, 2023

Description

Training of the traffic light classifier model isn't up-to-date. Model training and ONNX conversion scripts changed up-to-date repos of mmlab.

I have updated the custom training and detailed more.

autowarefoundation/autoware-documentation#447

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>
@kaancolak kaancolak requested a review from yukke42 September 7, 2023 10:43
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Sep 7, 2023
@kaancolak
Copy link
Contributor Author

@yukke42 @miursh @yukkysaito Could you look into this PR?

@yukkysaito
Copy link
Contributor

yukkysaito commented Sep 7, 2023

Thank you for your PR 👍
Autoware Documentation might be better written where it is implementation-independent.
@mitsudome-r
In that case, would it be better to skip the link from Autoware Documentation to README.md?

@kaancolak
Copy link
Contributor Author

kaancolak commented Sep 8, 2023

Thank you for your PR 👍 Autoware Documentation might be better written where it is implementation-independent. @mitsudome-r In that case, would it be better to skip the link from Autoware Documentation to README.md?

@yukkysaito Saito-san thanks for your feedback. Mitsudome-san also agrees with you, I will refactor PR after it is done.

@yukkysaito
Copy link
Contributor

@mitsudome-r How about you?

@kaancolak
Copy link
Contributor Author

@mitsudome-r How about you?

@yukkysaito Saito-san, he also has the same idea as you. I updated the PR.

After @xmfcx upload traffic_light_sample_dataset to AWS, I will open PR to review.

@kaancolak kaancolak marked this pull request as draft September 12, 2023 15:04
@kaancolak kaancolak marked this pull request as ready for review September 13, 2023 16:32
@kaancolak
Copy link
Contributor Author

@yukkysaito @miursh @yukke42 Could you review this PR or assign an appropriate reviewer? FYI: @mitsudome-r

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitsudome-r mitsudome-r added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 15, 2023
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.51% 🎉

Comparison is base (4dd6960) 15.14% compared to head (76b52e8) 15.65%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4917      +/-   ##
==========================================
+ Coverage   15.14%   15.65%   +0.51%     
==========================================
  Files        1581     1584       +3     
  Lines      110014   108904    -1110     
  Branches    34487    33280    -1207     
==========================================
+ Hits        16660    17054     +394     
+ Misses      74710    73353    -1357     
+ Partials    18644    18497     -147     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 15.65% <ø> (+0.51%) ⬆️ Carriedforward from 3e03a0d

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
localization/ekf_localizer/src/ekf_localizer.cpp 0.00% <ø> (ø)
...on_planner/src/mission_planner/mission_planner.cpp 0.00% <ø> (ø)

... and 149 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaancolak kaancolak enabled auto-merge (squash) September 21, 2023 11:10
@kaancolak kaancolak merged commit 68e64ac into autowarefoundation:main Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants