Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): remove motion_utils.hpp and tier4_autoware_utils.hpp control/ #4844

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Sep 1, 2023

Description

#4821

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Sep 1, 2023
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the build-fast2/component/control/remove-motion_utils_tier4_autoware_utils_hpp branch from 6eb053a to 5f712f3 Compare September 1, 2023 04:34
@github-actions github-actions bot removed component:planning Route planning, decision-making, and navigation. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Sep 1, 2023
@soblin soblin marked this pull request as ready for review September 1, 2023 06:20
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 1, 2023
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ade1c41) 15.12% compared to head (5f712f3) 15.12%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4844   +/-   ##
=======================================
  Coverage   15.12%   15.12%           
=======================================
  Files        1573     1573           
  Lines      108415   108415           
  Branches    33306    33306           
=======================================
  Hits        16395    16395           
  Misses      74148    74148           
  Partials    17872    17872           
Flag Coverage Δ *Carryforward flag
differential 19.56% <ø> (?)
total 15.12% <ø> (ø) Carriedforward from ade1c41

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
control/autonomous_emergency_braking/src/node.cpp 0.00% <ø> (ø)
.../lane_departure_checker/lane_departure_checker.hpp 0.00% <ø> (ø)
control/mpc_lateral_controller/src/mpc.cpp 46.73% <ø> (ø)
..._lateral_controller/src/mpc_lateral_controller.cpp 44.06% <ø> (ø)
control/mpc_lateral_controller/src/mpc_utils.cpp 50.44% <ø> (ø)
...ol/operation_mode_transition_manager/src/state.cpp 0.00% <ø> (ø)
...nal_controller/src/pid_longitudinal_controller.cpp 39.59% <ø> (ø)
...y_follower_node/src/simple_trajectory_follower.cpp 0.00% <ø> (ø)
control/vehicle_cmd_gate/src/vehicle_cmd_gate.hpp 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin
Copy link
Contributor Author

soblin commented Sep 2, 2023

@TakaHoribe @kyoichi-sugahara Can you approve this ?

@soblin soblin merged commit 1e0db7b into autowarefoundation:main Sep 4, 2023
@soblin soblin deleted the build-fast2/component/control/remove-motion_utils_tier4_autoware_utils_hpp branch September 4, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants