-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(avoidance): fix lateral distance calculation #4820
fix(avoidance): fix lateral distance calculation #4820
Conversation
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
4cc379f
to
cbf96c6
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4820 +/- ##
==========================================
- Coverage 15.11% 15.06% -0.06%
==========================================
Files 1573 1573
Lines 108324 108727 +403
Branches 33256 33533 +277
==========================================
+ Hits 16369 16375 +6
- Misses 74121 74495 +374
- Partials 17834 17857 +23
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…4820) * fix(avoidance): fix calculation logic for road shoulder distance Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(avoidance): fix overhang distance calculation Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(avoidance): don't set avoidable for invalid shift Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Description
🤖 Generated by Copilot at 4cc379f
The pull request improves the object avoidance logic in the behavior path planner by using the reference path instead of the ego pose to calculate the overhang and road shoulder distances of objects. It modifies the function
calcEnvelopeOverhangDistance
and updates its calls inavoidance_module.cpp
andavoidance_by_lane_change.cpp
.Before this PR
Since there is a bug in shiftable length caluclation logic, sometimes it outputs unfeasible (outside drivable area) avoidance path.
Psim
After this PR
In this PR, module calculates precise distance between object polygon and road shoulder so that it can judge if the ego is able to avoid and path is feasible.
Tests performed
Effects on system behavior
Fix invalid behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.