-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior_path_planner): fix left/right split of the drivable area #4738
Merged
maxime-clem
merged 2 commits into
autowarefoundation:main
from
maxime-clem:fix/dyn_da_left-right-split
Sep 1, 2023
Merged
fix(behavior_path_planner): fix left/right split of the drivable area #4738
maxime-clem
merged 2 commits into
autowarefoundation:main
from
maxime-clem:fix/dyn_da_left-right-split
Sep 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takayuki5168
approved these changes
Aug 31, 2023
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
8e1e3cf
to
bf51f63
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4738 +/- ##
=======================================
Coverage 15.12% 15.12%
=======================================
Files 1573 1573
Lines 108415 108418 +3
Branches 33306 33308 +2
=======================================
+ Hits 16395 16399 +4
+ Misses 74148 74147 -1
Partials 17872 17872
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
maxime-clem
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 5, 2023
…autowarefoundation#4738) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem
added a commit
to maxime-clem/autoware.universe
that referenced
this pull request
Sep 5, 2023
…autowarefoundation#4738) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Closed
4 tasks
maxime-clem
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 12, 2023
…autowarefoundation#4738) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 14, 2023
…autowarefoundation#4738) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 15, 2023
…autowarefoundation#4738) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
4 tasks
maxime-clem
added a commit
to maxime-clem/autoware.universe
that referenced
this pull request
Sep 25, 2023
…autowarefoundation#4738) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue when splitting the dynamically expanded drivable area. The issue happens when calculating the left and right bounds from the expanded polygon.
A function calculates the ranges of polygon points that will make the left and right bounds by selecting the start/end points of each bound. In this function, we check whether points are to the left or right of the path. This check was causing the issue and was improved.
Tests performed
Evaluation (TIER IV INTERNAL LINK): https://evaluation.tier4.jp/evaluation/reports/4443b361-435f-5689-8766-23f5f6314348?project_id=x2_dev
Psim
Effects on system behavior
Prevents some issue where the left and right bounds of the dynamically expanded drivable area would be wrong.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.