Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): make cut overlap lane logic better #4697

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Aug 22, 2023

Description

🤖 Generated by Copilot at 6f23079

This pull request enhances the behavior path planner by improving the code quality and the path point selection logic in utils.cpp. It adds a blank line for clarity and modifies the cutOverlappedLanes function to handle edge cases and avoid errors.

Tests performed

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 22, 2023
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (b048ff4) 14.89% compared to head (6f23079) 14.89%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4697      +/-   ##
==========================================
- Coverage   14.89%   14.89%   -0.01%     
==========================================
  Files        1549     1549              
  Lines      106955   106969      +14     
  Branches    32790    32796       +6     
==========================================
+ Hits        15927    15928       +1     
- Misses      73635    73649      +14     
+ Partials    17393    17392       -1     
Flag Coverage Δ *Carryforward flag
differential 13.24% <0.00%> (?)
total 14.89% <ø> (+<0.01%) ⬆️ Carriedforward from b048ff4

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
planning/behavior_path_planner/src/utils/utils.cpp 15.28% <0.00%> (-0.09%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota merged commit ae0ad53 into autowarefoundation:main Aug 23, 2023
@satoshi-ota satoshi-ota deleted the fix/cut-overlap-lane branch August 23, 2023 12:30
kosuke55 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 24, 2023
* fix(utils): fix longitudinal length inconsistency

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(utils): improve logic

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
kosuke55 pushed a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2023
* fix(utils): fix longitudinal length inconsistency

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(utils): improve logic

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants