Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avoidance): fix target search area width calculation #4671

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Aug 19, 2023

Description

🤖 Generated by Copilot at a9b6122

Increase the offset for object separation by path in utils.cpp to prevent collisions with large vehicles.

Related to #4525


For now module calculates detection area width from avoidance margin parameter and create detection area along previous output path. But sometimes this logic causes chettering like this ⬇️ .

simplescreenrecorder-2023-08-20_08.04.14.mp4
  1. detect object
  2. create avoidance path
  3. switch the path & update detection area
  4. the object is outside of the detection area that is created in step3
  5. avoidance maneuver is canceled

Then, I increase detection area margin in order to prevent this chattering.

Tests performed

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 19, 2023
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 19, 2023
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (bc86f0e) 14.90% compared to head (7772f3f) 14.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4671   +/-   ##
=======================================
  Coverage   14.90%   14.90%           
=======================================
  Files        1548     1548           
  Lines      106793   106794    +1     
  Branches    32682    32682           
=======================================
+ Hits        15917    15918    +1     
  Misses      73552    73552           
  Partials    17324    17324           
Flag Coverage Δ *Carryforward flag
differential 13.25% <100.00%> (?)
total 14.90% <ø> (-0.01%) ⬇️ Carriedforward from bc86f0e

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ehavior_path_planner/src/utils/avoidance/utils.cpp 9.56% <100.00%> (+0.12%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@satoshi-ota satoshi-ota merged commit 73b2877 into autowarefoundation:main Aug 21, 2023
@satoshi-ota satoshi-ota deleted the fix/avoid-margin branch August 21, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants