Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(obstacle_avoidance_planner): smaller calculation time #4608

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Aug 12, 2023

Description

  • Decreased default debug markers to publish
    • Circles visualization is a bit heavy.
    • Extra debug markers can be published by changing a flag.
  • Effective multiple nearest index search in the for loop with calcSegmentLengthVector.
  • Modify the script to plot the calculation time of functions which is or may be heavy.

Evaluation with sample map

without the PR
image

with the PR
replan every 1 second (default)
image

FYI: replan every cycle
image

Evaluation with odaiba map

without the PR
image

with the PR
replan every 1 second (default)
image

FYI: replan every cycle
image

Tests performed

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 12, 2023
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 12, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review August 12, 2023 17:22
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the feat/obstacle-avoidance-fast branch from 82835b9 to b48f980 Compare August 13, 2023 18:43
@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Patch coverage: 37.50% and project coverage change: +0.02% 🎉

Comparison is base (7f02d6a) 14.82% compared to head (b48f980) 14.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4608      +/-   ##
==========================================
+ Coverage   14.82%   14.85%   +0.02%     
==========================================
  Files        1529     1529              
  Lines      105811   105846      +35     
  Branches    32243    32264      +21     
==========================================
+ Hits        15690    15721      +31     
+ Misses      72965    72961       -4     
- Partials    17156    17164       +8     
Flag Coverage Δ *Carryforward flag
differential 37.51% <37.50%> (?)
total 14.82% <ø> (+<0.01%) ⬆️ Carriedforward from 7f02d6a

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...clude/obstacle_avoidance_planner/mpt_optimizer.hpp 85.71% <ø> (ø)
...lanner/include/obstacle_avoidance_planner/node.hpp 40.00% <ø> (ø)
...ng/obstacle_avoidance_planner/src/debug_marker.cpp 40.11% <0.00%> (-0.80%) ⬇️
planning/obstacle_avoidance_planner/src/node.cpp 41.60% <47.05%> (+3.62%) ⬆️
...g/obstacle_avoidance_planner/src/mpt_optimizer.cpp 40.11% <55.55%> (+0.19%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 merged commit eeeca38 into autowarefoundation:main Aug 15, 2023
@takayuki5168 takayuki5168 deleted the feat/obstacle-avoidance-fast branch August 15, 2023 02:32
LeoDriveProject pushed a commit to leo-drive/autoware.universe.golf that referenced this pull request Aug 16, 2023
…oundation#4608)

* perf(obstacle_avoidance_planner): smaller calculation time

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update script

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
rej55 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 18, 2023
…oundation#4608)

* perf(obstacle_avoidance_planner): smaller calculation time

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update script

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Aug 21, 2023
…oundation#4608)

* perf(obstacle_avoidance_planner): smaller calculation time

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update script

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Nov 16, 2023
…oundation#4608)

* perf(obstacle_avoidance_planner): smaller calculation time

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update script

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Nov 25, 2023
…oundation#4608)

* perf(obstacle_avoidance_planner): smaller calculation time

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update script

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Nov 26, 2023
…oundation#4608)

* perf(obstacle_avoidance_planner): smaller calculation time

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update script

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Dec 25, 2023
…oundation#4608)

* perf(obstacle_avoidance_planner): smaller calculation time

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update script

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants