-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(start_planner): fix geometric parallel parking lane ids #4603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55
requested review from
rej55,
takayuki5168,
purewater0901,
zulfaqar-azmi-t4,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe and
tkimura4
as code owners
August 12, 2023 04:25
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Aug 12, 2023
kosuke55
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Aug 12, 2023
merge #4604 first |
takayuki5168
approved these changes
Aug 12, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4603 +/- ##
==========================================
+ Coverage 14.82% 14.90% +0.08%
==========================================
Files 1531 1531
Lines 105766 106337 +571
Branches 32155 32560 +405
==========================================
+ Hits 15680 15851 +171
- Misses 72961 73282 +321
- Partials 17125 17204 +79
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55
added
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
and removed
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
labels
Aug 13, 2023
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 14, 2023
…foundation#4603) * fix(start_planner): fix geometric parallel parking lane ids Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix stop path drivable lanes Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
LeoDriveProject
pushed a commit
to leo-drive/autoware.universe.golf
that referenced
this pull request
Aug 16, 2023
…foundation#4603) * fix(start_planner): fix geometric parallel parking lane ids Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix stop path drivable lanes Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kminoda
pushed a commit
to kminoda/autoware.universe
that referenced
this pull request
Aug 21, 2023
…foundation#4603) * fix(start_planner): fix geometric parallel parking lane ids Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix stop path drivable lanes Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 22, 2023
…foundation#4603) * fix(start_planner): fix geometric parallel parking lane ids Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix stop path drivable lanes Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
correct geometric parallel parking lane ids to fix wrong drivable area and path cut etc.
Related links
Tests performed
psim
Notes for reviewers
Interface changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.