-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(avoidance): output unconfortable path with unsafe state #4536
feat(avoidance): output unconfortable path with unsafe state #4536
Conversation
816a70f
to
71f810d
Compare
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
71f810d
to
55a467c
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4536 +/- ##
==========================================
- Coverage 14.80% 14.77% -0.04%
==========================================
Files 1527 1527
Lines 105673 105990 +317
Branches 32107 32314 +207
==========================================
+ Hits 15649 15660 +11
- Misses 72945 73224 +279
- Partials 17079 17106 +27
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@@ -616,28 +622,28 @@ void AvoidanceModule::updateEgoBehavior(const AvoidancePlanningData & data, Shif | |||
return; | |||
} | |||
|
|||
insertPrepareVelocity(path); | |||
// insertPrepareVelocity(path); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…efoundation#4536) * feat(avoidance): output unconfortable path with unsafe state Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): make it selectable avoidance policy Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…efoundation#4536) * feat(avoidance): output unconfortable path with unsafe state Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): make it selectable avoidance policy Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Description
🤖 Generated by Copilot at 816a70f
Refactor
AvoidanceModule
class to improve shift line planning for obstacle avoidance. AddisComfortable
function andcomfortable
flag to filter out uncomfortable shift lines.Add some options to configurate avoidance policy.
Additionally, make it possible to output unsafe (=lateral jerk exceeds limit value) path with unsafe state.
simplescreenrecorder-2023-08-09_12.05.53.mp4
Tests performed
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.