Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crosswalk): fix the doc of TTC-TTV graph #4480

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Aug 1, 2023

Description

Fixed the doc of TTC/TTV graph.

Previously, ego_pass_first and ego_pass_later are opposite.
image

Tests performed

No need.

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Aug 1, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review August 1, 2023 02:04
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e35f14d) 14.90% compared to head (5ee7b9c) 14.90%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4480   +/-   ##
=======================================
  Coverage   14.90%   14.90%           
=======================================
  Files        1520     1520           
  Lines      104772   104772           
  Branches    31899    31899           
=======================================
  Hits        15619    15619           
  Misses      72098    72098           
  Partials    17055    17055           
Flag Coverage Δ *Carryforward flag
differential 11.14% <ø> (?)
total 14.90% <ø> (ø) Carriedforward from e35f14d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 merged commit a5d0a7d into autowarefoundation:main Aug 1, 2023
@takayuki5168 takayuki5168 deleted the fix/crosswalk-doc-ttc-ttv branch August 1, 2023 11:16
felixf4xu pushed a commit to felixf4xu/autoware.universe that referenced this pull request Aug 2, 2023
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Felix F Xu <felixfxu@gmail.com>
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Aug 9, 2023
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Sep 15, 2023
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants