-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(crosswalk): add option to disable yield for new stopped object #4465
Merged
takayuki5168
merged 4 commits into
autowarefoundation:main
from
tier4:feat/disable-yield-for-stopped-object
Aug 1, 2023
Merged
feat(crosswalk): add option to disable yield for new stopped object #4465
takayuki5168
merged 4 commits into
autowarefoundation:main
from
tier4:feat/disable-yield-for-stopped-object
Aug 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
4 tasks
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4465 +/- ##
==========================================
- Coverage 14.91% 14.91% -0.01%
==========================================
Files 1517 1517
Lines 104695 104707 +12
Branches 31880 31893 +13
==========================================
Hits 15619 15619
- Misses 72024 72034 +10
- Partials 17052 17054 +2
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
satoshi-ota
approved these changes
Aug 1, 2023
felixf4xu
pushed a commit
to felixf4xu/autoware.universe
that referenced
this pull request
Aug 2, 2023
…utowarefoundation#4465) * feat(crosswalk): disable cancel yield at no traffic signals intersection Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat(crosswalk): add option to disable yield for new stopped object Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update config Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Felix F Xu <felixfxu@gmail.com>
takayuki5168
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 9, 2023
…utowarefoundation#4465) * feat(crosswalk): disable cancel yield at no traffic signals intersection Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat(crosswalk): add option to disable yield for new stopped object Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update config Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
satoshi-ota
pushed a commit
to satoshi-ota/autoware.universe
that referenced
this pull request
Sep 15, 2023
…utowarefoundation#4465) * feat(crosswalk): disable cancel yield at no traffic signals intersection Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat(crosswalk): add option to disable yield for new stopped object Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update config Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on #4463
Add an option to disable yield for new stopped object.
This option is to achieve aggressive behavior for complex scenes as follows.
![image](https://private-user-images.githubusercontent.com/20228327/257137423-f68514f5-7bca-4737-a0a7-40b7daee8797.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMjQwMDUsIm5iZiI6MTczOTMyMzcwNSwicGF0aCI6Ii8yMDIyODMyNy8yNTcxMzc0MjMtZjY4NTE0ZjUtN2JjYS00NzM3LWEwYTctNDBiN2RhZWU4Nzk3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDAxMjgyNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkyZTI4NzIwNjNiZjkwNmQxMWIyYmQzN2E4YWU4MDQ5YzBjZjNhYjIxNzVmNDM5NmVmZjA4ZjBjZjExYmNjOGUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.YYV2pWBXYnl5foaBxwynclQ6PI69YClnRnd_mObdlQI)
In this situation, the pedestrians often appear or disappear due to occlusion and perception's performance limitation.
In order not to yield for 3 seconds for new appeared pedestrians, this option will be useful.
Tests performed
Effects on system behavior
Nothing by default
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.