refactor(behavior_velocity_stop_line_module): clean stop line module #4394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yutaka <purewater0901@gmail.com>
shmpwk
approved these changes
Jul 26, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4394 +/- ##
=======================================
Coverage 14.93% 14.93%
=======================================
Files 1515 1515
Lines 104545 104545
Branches 31777 31777
=======================================
Hits 15615 15615
Misses 71894 71894
Partials 17036 17036
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
PhoebeWu21
pushed a commit
to PhoebeWu21/autoware.universe
that referenced
this pull request
Aug 18, 2023
…utowarefoundation#4394) Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove unnecessary and unused parameters. Also, rename a parameter to make it easier for users to understand. I also updated the parameter explanation part of the behavior velocity stop line module document.
Related PR
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.